src/ic/ic.cc - Issue 1358423002: [es6] Introduce spec compliant IsConstructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 1358423002: [es6] Introduce spec compliant IsConstructor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comment Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index 99a79d93688091799a237bff03cf9cd214542be2..d48f3b2fa349629bc3850c0cea7e8bd7ce582398 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -1159,7 +1159,7 @@ Handle<Code> LoadIC::CompileHandler(LookupIterator* lookup,

// Use specialized code for getting prototype of functions.

if (receiver->IsJSFunction() &&

Name::Equals(isolate()->factory()->prototype_string(), lookup->name()) &&

- Handle<JSFunction>::cast(receiver)->should_have_prototype() &&

+ receiver->IsConstructor() &&

!Handle<JSFunction>::cast(receiver)

->map()

->has_non_instance_prototype()) {