[es6] Introduce spec compliant IsConstructor.

[es6] Introduce spec compliant IsConstructor.

There was already a bit on the Map named "function with prototype",
which basically meant that the Map was a map for a JSFunction that could
be used as a constructor. Now this CL generalizes that bit to
IsConstructor, which says that whatever (Heap)Object you are looking at
can be used as a constructor (i.e. the bit is also set for bound
functions that can be used as constructors and proxies that have a
[[Construct]] internal method).

This way we have a single chokepoint for IsConstructor checking, which
allows us to get rid of the various ways in which we tried to guess
whether something could be used as a constructor or not.

Drive-by-fix: Renamed IsConstructor on FunctionKind to
IsClassConstructor to resolve the weird name clash, and the
IsClassConstructor name also matches the spec.

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg
R=jarin@chromium.org, rossberg@chromium.org
BUG=v8:4413, v8:4430
LOG=n

Committed: https://crrev.com/8de4d9351df4cf66c8a128d561a6e331d196be54
Cr-Commit-Position: refs/heads/master@{#30900}

Committed: https://crrev.com/8fe3ac07014ce5891be0a1cbd8019e9f3b02ff0b
Cr-Commit-Position: refs/heads/master@{#30902}

[Benedikt Meurer, 2015-09-23 07:41:21]

Andreas: Please check language aspects.
Jaro: Please check builtins.

Thanks,
Benedikt

[Benedikt Meurer, 2015-09-23 07:41:28]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-09-23 07:41:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358423002/1

[commit-bot: I haz the power, 2015-09-23 07:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 07:41:38]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Benedikt Meurer, 2015-09-23 07:42:40]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 07:42:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358423002/1

[Jarin, 2015-09-23 08:00:18]

lgtm. awesome!

[rossberg, 2015-09-23 08:56:11]

LGTM modulo nits

https://codereview.chromium.org/1358423002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/1358423002/diff/1/src/bootstrapper.cc#newcode490
src/bootstrapper.cc:490:
map->set_is_constructor(IsFunctionModeWithPrototype(function_mode));
Should IsFunctionModeWithPrototype also be renamed?

https://codereview.chromium.org/1358423002/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1358423002/diff/1/src/objects-inl.h#newcode4542
src/objects-inl.h:4542: if (value) {
Nit: compress with ?: operator?

https://codereview.chromium.org/1358423002/diff/1/src/runtime/runtime-object.cc
File src/runtime/runtime-object.cc (right):

https://codereview.chromium.org/1358423002/diff/1/src/runtime/runtime-object....
src/runtime/runtime-object.cc:1059: // If function should not have prototype,
construction is not allowed. In this
Update comment.

[Benedikt Meurer, 2015-09-23 09:38:15]

https://codereview.chromium.org/1358423002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/1358423002/diff/1/src/bootstrapper.cc#newcode490
src/bootstrapper.cc:490:
map->set_is_constructor(IsFunctionModeWithPrototype(function_mode));
Maybe, but I'd do that in a separate CL.

https://codereview.chromium.org/1358423002/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1358423002/diff/1/src/objects-inl.h#newcode4542
src/objects-inl.h:4542: if (value) {
I prefer to keep it explicit (as the other cases).

https://codereview.chromium.org/1358423002/diff/1/src/runtime/runtime-object.cc
File src/runtime/runtime-object.cc (right):

https://codereview.chromium.org/1358423002/diff/1/src/runtime/runtime-object....
src/runtime/runtime-object.cc:1059: // If function should not have prototype,
construction is not allowed. In this
On 2015/09/23 08:56:10, rossberg wrote:
> Update comment.

Done.

[Benedikt Meurer, 2015-09-23 09:38:22]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 09:38:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358423002/20001

[commit-bot: I haz the power, 2015-09-23 11:41:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 11:41:29]

Dry run: Try jobs failed on following builders:
  v8_linux_layout_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_layout_dbg/builds/...)

[Benedikt Meurer, 2015-09-24 03:58:49]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-09-24 03:58:50]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org,
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1358423002/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2015-09-24 03:59:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358423002/20001

[commit-bot: I haz the power, 2015-09-24 04:00:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-24 04:00:48]

Patchset 2 (id:??) landed as
https://crrev.com/8de4d9351df4cf66c8a128d561a6e331d196be54
Cr-Commit-Position: refs/heads/master@{#30900}

[Benedikt Meurer, 2015-09-24 05:26:19]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1360403002/ by bmeurer@chromium.org.

The reason for reverting is: Failed on Fuzzer and MIPS bot..

[paul.l..., 2015-09-24 05:28:20]

paul.lind@imgtec.com changed reviewers:
+ paul.lind@imgtec.com

[paul.l..., 2015-09-24 05:28:21]

https://codereview.chromium.org/1358423002/diff/20001/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):

https://codereview.chromium.org/1358423002/diff/20001/src/mips/builtins-mips....
src/mips/builtins-mips.cc:1688: __ lw(t1, FieldMemOperand(t1,
HeapObject::kMapOffset));
Benedikt - looks like this should load from (a1, HeapObject::kMapOffset).

I'll start tests now, but guessing it fixes it.

[Benedikt Meurer, 2015-09-24 05:29:03]

On 2015/09/24 05:28:21, paul.l... wrote:
>
https://codereview.chromium.org/1358423002/diff/20001/src/mips/builtins-mips.cc
> File src/mips/builtins-mips.cc (right):
> 
>
https://codereview.chromium.org/1358423002/diff/20001/src/mips/builtins-mips....
> src/mips/builtins-mips.cc:1688: __ lw(t1, FieldMemOperand(t1,
> HeapObject::kMapOffset));
> Benedikt - looks like this should load from (a1, HeapObject::kMapOffset).
> 
> I'll start tests now, but guessing it fixes it.

Aye, will fix that, thanks. Already found the cause for the fuzzer failure

[paul.l..., 2015-09-24 05:31:34]

On 2015/09/24 05:29:03, Benedikt Meurer wrote:
> Aye, will fix that, thanks. Already found the cause for the fuzzer failure

MIPS64 port has same issue.

[Benedikt Meurer, 2015-09-24 05:31:57]

On 2015/09/24 05:31:34, paul.l... wrote:
> On 2015/09/24 05:29:03, Benedikt Meurer wrote:
> > Aye, will fix that, thanks. Already found the cause for the fuzzer failure
> 
> MIPS64 port has same issue.

Indeed (copy-and-paste). Thanks for spotting!

[Benedikt Meurer, 2015-09-24 05:34:37]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-09-24 05:34:37]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org,
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1358423002/#ps40001
(title: "Fix stupid fuzzer failure (constructor bit set on sloppy/strict
arguments). Fix MIPS/MIPS64 typos, …")

[commit-bot: I haz the power, 2015-09-24 05:34:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358423002/40001

[paul.l..., 2015-09-24 05:44:03]

The fix passes check. As you will see soon enough :-)

[Benedikt Meurer, 2015-09-24 05:54:29]

On 2015/09/24 05:44:03, paul.l... wrote:
> The fix passes check. As you will see soon enough :-)

Thanks :-)

[commit-bot: I haz the power, 2015-09-24 06:50:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-24 06:50:26]

Patchset 3 (id:??) landed as
https://crrev.com/8fe3ac07014ce5891be0a1cbd8019e9f3b02ff0b
Cr-Commit-Position: refs/heads/master@{#30902}