Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: ui/views/view_unittest.cc

Issue 13584010: views: Migrate the cases of "new .*NativeTextButton(" to LabelButton. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one more fix in one_click_signin_bubble_view.cc Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/view_unittest.cc
diff --git a/ui/views/view_unittest.cc b/ui/views/view_unittest.cc
index a8c1f56b2cef9137adadfed7bfc8ec28df48d714..d20997ff250123bd4bbd6f86d896fa74aa74199a 100644
--- a/ui/views/view_unittest.cc
+++ b/ui/views/view_unittest.cc
@@ -1847,34 +1847,6 @@ TEST_F(ButtonDropDownTest, RegularClickTest) {
}
////////////////////////////////////////////////////////////////////////////////
-// View hierarchy / Visibility changes
-////////////////////////////////////////////////////////////////////////////////
-/*
-TEST_F(ViewTest, ChangeVisibility) {
msw 2013/04/04 02:31:03 +oshima to see if this should be deleted or left t
-#if defined(OS_LINUX)
- // Make CRITICAL messages fatal
- // TODO(oshima): we probably should enable this for entire tests on linux.
- g_log_set_always_fatal(G_LOG_LEVEL_CRITICAL);
-#endif
- scoped_ptr<Widget> window(CreateWidget());
- window->Init(NULL, gfx::Rect(0, 0, 500, 300));
- View* root_view = window->GetRootView();
- NativeTextButton* native = new NativeTextButton(NULL, ASCIIToUTF16("Native"));
-
- root_view->SetContentsView(native);
- native->SetVisible(true);
-
- root_view->RemoveChildView(native);
- native->SetVisible(false);
- // Change visibility to true with no widget.
- native->SetVisible(true);
-
- root_view->SetContentsView(native);
- native->SetVisible(true);
-}
-*/
-
-////////////////////////////////////////////////////////////////////////////////
// Native view hierachy
////////////////////////////////////////////////////////////////////////////////
class TestNativeViewHierarchy : public View {

Powered by Google App Engine
This is Rietveld 408576698