Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: ui/views/focus/focus_traversal_unittest.cc

Issue 13584010: views: Migrate the cases of "new .*NativeTextButton(" to LabelButton. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one more fix in one_click_signin_bubble_view.cc Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/focus/focus_traversal_unittest.cc
diff --git a/ui/views/focus/focus_traversal_unittest.cc b/ui/views/focus/focus_traversal_unittest.cc
index 61ca85205b15055c4bce252743a14ebcaf62f79f..6ec4b9d605390aefe97d7316e1af1e942dc659a5 100644
--- a/ui/views/focus/focus_traversal_unittest.cc
+++ b/ui/views/focus/focus_traversal_unittest.cc
@@ -8,8 +8,8 @@
#include "base/utf_string_conversions.h"
#include "ui/base/models/combobox_model.h"
#include "ui/views/controls/button/checkbox.h"
+#include "ui/views/controls/button/label_button.h"
#include "ui/views/controls/button/radio_button.h"
-#include "ui/views/controls/button/text_button.h"
#include "ui/views/controls/combobox/combobox.h"
#include "ui/views/controls/label.h"
#include "ui/views/controls/link.h"
@@ -102,7 +102,7 @@ class PaneView : public View, public FocusTraversable {
focus_search_ = focus_search;
}
- // Overridden from views::View:
+ // Overridden from View:
virtual FocusTraversable* GetPaneFocusTraversable() OVERRIDE {
if (focus_search_)
return this;
@@ -110,8 +110,8 @@ class PaneView : public View, public FocusTraversable {
return NULL;
}
- // Overridden from views::FocusTraversable:
- virtual views::FocusSearch* GetFocusSearch() OVERRIDE {
+ // Overridden from FocusTraversable:
+ virtual FocusSearch* GetFocusSearch() OVERRIDE {
return focus_search_;
}
virtual FocusTraversable* GetFocusTraversableParent() OVERRIDE {
@@ -357,8 +357,8 @@ void FocusTraversalTest::InitContentView() {
y += label_height + gap_between_labels;
- NativeTextButton* button = new NativeTextButton(NULL,
- ASCIIToUTF16("Click me"));
+ LabelButton* button = new LabelButton(NULL, ASCIIToUTF16("Click me"));
+ button->SetStyle(Button::STYLE_NATIVE_TEXTBUTTON);
button->SetBounds(label_x, y + 10, 80, 30);
button->set_id(kFruitButtonID);
left_container_->AddChildView(button);
@@ -453,19 +453,22 @@ void FocusTraversalTest::InitContentView() {
y = 250;
int width = 60;
- button = new NativeTextButton(NULL, ASCIIToUTF16("OK"));
+ button = new LabelButton(NULL, ASCIIToUTF16("OK"));
+ button->SetStyle(Button::STYLE_NATIVE_TEXTBUTTON);
button->set_id(kOKButtonID);
button->SetIsDefault(true);
GetContentsView()->AddChildView(button);
button->SetBounds(150, y, width, 30);
- button = new NativeTextButton(NULL, ASCIIToUTF16("Cancel"));
+ button = new LabelButton(NULL, ASCIIToUTF16("Cancel"));
+ button->SetStyle(Button::STYLE_NATIVE_TEXTBUTTON);
button->set_id(kCancelButtonID);
GetContentsView()->AddChildView(button);
button->SetBounds(220, y, width, 30);
- button = new NativeTextButton(NULL, ASCIIToUTF16("Help"));
+ button = new LabelButton(NULL, ASCIIToUTF16("Help"));
+ button->SetStyle(Button::STYLE_NATIVE_TEXTBUTTON);
button->set_id(kHelpButtonID);
GetContentsView()->AddChildView(button);
button->SetBounds(290, y, width, 30);
@@ -518,7 +521,8 @@ void FocusTraversalTest::InitContentView() {
text_field->SetBounds(10, 10, 100, 20);
text_field->set_id(kSearchTextfieldID);
- button = new NativeTextButton(NULL, ASCIIToUTF16("Search"));
+ button = new LabelButton(NULL, ASCIIToUTF16("Search"));
+ button->SetStyle(Button::STYLE_NATIVE_TEXTBUTTON);
contents->AddChildView(button);
button->SetBounds(112, 5, 60, 30);
button->set_id(kSearchButtonID);
@@ -541,11 +545,13 @@ void FocusTraversalTest::InitContentView() {
contents->set_focusable(true);
contents->set_background(Background::CreateSolidBackground(SK_ColorBLUE));
contents->set_id(kThumbnailContainerID);
- button = new NativeTextButton(NULL, ASCIIToUTF16("Star"));
+ button = new LabelButton(NULL, ASCIIToUTF16("Star"));
+ button->SetStyle(Button::STYLE_NATIVE_TEXTBUTTON);
contents->AddChildView(button);
button->SetBounds(5, 5, 50, 30);
button->set_id(kThumbnailStarID);
- button = new NativeTextButton(NULL, ASCIIToUTF16("SuperStar"));
+ button = new LabelButton(NULL, ASCIIToUTF16("SuperStar"));
+ button->SetStyle(Button::STYLE_NATIVE_TEXTBUTTON);
contents->AddChildView(button);
button->SetBounds(60, 5, 100, 30);
button->set_id(kThumbnailSuperStarID);

Powered by Google App Engine
This is Rietveld 408576698