Issue 1358373003: Add warmup bench to visual bench

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1358373003: Add warmup bench to visual bench (Closed)

Created:
5 years, 2 months ago by joshua.litt

Modified:
5 years, 2 months ago

Reviewers:
joshualitt, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add warmup bench to visual bench BUG=skia: Committed: https://skia.googlesource.com/skia/+/7d4b458b9fa063bd88d04390ed2e58d5676a3ae8

Patch Set 1 #

Patch Set 2 : tweaks #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -7 lines)			Patch
M	bench/RectBench.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/VisualBench/VisualLightweightBenchModule.h	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download
M	tools/VisualBench/VisualLightweightBenchModule.cpp	View	1	9 chunks	+51 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bsalomon

On 2015/09/23 17:31:28, joshualitt wrote: > ptal lgtm if you still want to land this.

5 years, 2 months ago (2015-09-24 12:30:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358373003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358373003/20001

5 years, 2 months ago (2015-09-24 15:03:17 UTC) #5

commit-bot: I haz the power

5 years, 2 months ago (2015-09-24 15:08:29 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7d4b458b9fa063bd88d04390ed2e58d5676a3ae8

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages