Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Side by Side Diff: base/memory/scoped_ptr_unittest.cc

Issue 1358373002: Change scoped_ptr::reset()'s behaviour to match unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Expand comment. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/memory/scoped_ptr.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_ptr.h" 5 #include "base/memory/scoped_ptr.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 675 matching lines...) Expand 10 before | Expand all | Expand 10 after
686 TEST(ScopedPtrTest, LoggingDoesntConvertToBoolean) { 686 TEST(ScopedPtrTest, LoggingDoesntConvertToBoolean) {
687 scoped_ptr<int> x(new int); 687 scoped_ptr<int> x(new int);
688 std::stringstream s1; 688 std::stringstream s1;
689 s1 << x; 689 s1 << x;
690 690
691 std::stringstream s2; 691 std::stringstream s2;
692 s2 << x.get(); 692 s2 << x.get();
693 693
694 EXPECT_EQ(s2.str(), s1.str()); 694 EXPECT_EQ(s2.str(), s1.str());
695 } 695 }
696
697 TEST(ScopedPtrTest, ReferenceCycle) {
698 struct StructB;
699 struct StructA {
700 scoped_ptr<StructB> b;
701 };
702
703 struct StructB {
704 scoped_ptr<StructA> a;
705 };
706
707 // Create a reference cycle.
708 StructA* a = new StructA;
709 a->b.reset(new StructB);
710 a->b->a.reset(a);
711
712 // Break the cycle by calling reset(). This will cause |a| (and hence, |a.b|)
713 // to be deleted before the call to reset() returns. This tests that the
714 // implementation of scoped_ptr::reset() doesn't access |this| after it
715 // deletes the underlying pointer. This behaviour is consistent with the
716 // definition of unique_ptr::reset in C++11.
717 a->b.reset();
718 }
OLDNEW
« no previous file with comments | « base/memory/scoped_ptr.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698