mojo/public/cpp/bindings/struct_ptr.h - Issue 1358353002: * Change C++ serialization/deserialization to not be move-only operations (with the except of |Ha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/struct_ptr.h

Issue 1358353002: * Change C++ serialization/deserialization to not be move-only operations (with the except of |Ha… (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: (*it).get() to it->, and other formatting Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/cpp/bindings/struct_ptr.h

diff --git a/mojo/public/cpp/bindings/struct_ptr.h b/mojo/public/cpp/bindings/struct_ptr.h

index 04a8130fc65ba31edc1d7bd83ef87ea75962b6d4..b47a1ed0d039e81de3ec19233ac648f5280c2243 100644

--- a/mojo/public/cpp/bindings/struct_ptr.h

+++ b/mojo/public/cpp/bindings/struct_ptr.h

@@ -150,7 +150,7 @@ class InlinedStructPtr {

MOJO_DCHECK(!is_null_);

return &value_;

}

- Struct* get() const { return &value_; }

+ Struct* get() const { return is_null() ? nullptr : &value_; }

void Swap(InlinedStructPtr* other) {

std::swap(value_, other->value_);

« no previous file with comments | « mojo/public/cpp/bindings/map.h ('k') | mojo/public/cpp/bindings/tests/array_unittest.cc » ('j') | no next file with comments »