mojo/public/cpp/bindings/tests/array_unittest.cc - Issue 1358353002: * Change C++ serialization/deserialization to not be move-only operations (with the except of |Ha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/array_unittest.cc

Issue 1358353002: * Change C++ serialization/deserialization to not be move-only operations (with the except of |Ha… (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/lib/control_message_proxy.cc ('K') | « mojo/public/cpp/bindings/struct_ptr.h ('k') | mojo/public/cpp/bindings/tests/map_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/array_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/array_unittest.cc b/mojo/public/cpp/bindings/tests/array_unittest.cc

index 293dc955ac670df202338f1ece64b30f1e1f77d3..c54d55944ff8ea32f30f5a4283b2768dbf369458 100644

--- a/mojo/public/cpp/bindings/tests/array_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/array_unittest.cc

@@ -160,7 +160,7 @@ TEST_F(ArrayTest, Serialization_ArrayOfPOD) {

FixedBufferForTesting buf(size);

Array_Data<int32_t>* data;

ArrayValidateParams validate_params(0, false, nullptr);

- SerializeArray_(array.Pass(), &buf, &data, &validate_params);

+ SerializeArray_(&array, &buf, &data, &validate_params);

Array<int32_t> array2;

Deserialize_(data, &array2);

@@ -178,7 +178,7 @@ TEST_F(ArrayTest, Serialization_EmptyArrayOfPOD) {

FixedBufferForTesting buf(size);

Array_Data<int32_t>* data;

ArrayValidateParams validate_params(0, false, nullptr);

- SerializeArray_(array.Pass(), &buf, &data, &validate_params);

+ SerializeArray_(&array, &buf, &data, &validate_params);

Array<int32_t> array2;

Deserialize_(data, &array2);

@@ -201,7 +201,7 @@ TEST_F(ArrayTest, Serialization_ArrayOfArrayOfPOD) {

Array_Data<Array_Data<int32_t>*>* data;

ArrayValidateParams validate_params(

0, false, new ArrayValidateParams(0, false, nullptr));

- SerializeArray_(array.Pass(), &buf, &data, &validate_params);

+ SerializeArray_(&array, &buf, &data, &validate_params);

Array<Array<int32_t>> array2;

Deserialize_(data, &array2);

@@ -226,7 +226,7 @@ TEST_F(ArrayTest, Serialization_ArrayOfBool) {

FixedBufferForTesting buf(size);

Array_Data<bool>* data;

ArrayValidateParams validate_params(0, false, nullptr);

- SerializeArray_(array.Pass(), &buf, &data, &validate_params);

+ SerializeArray_(&array, &buf, &data, &validate_params);

Array<bool> array2;

Deserialize_(data, &array2);

@@ -254,7 +254,7 @@ TEST_F(ArrayTest, Serialization_ArrayOfString) {

Array_Data<String_Data*>* data;

ArrayValidateParams validate_params(

0, false, new ArrayValidateParams(0, false, nullptr));

- SerializeArray_(array.Pass(), &buf, &data, &validate_params);

+ SerializeArray_(&array, &buf, &data, &validate_params);

Array<String> array2;

Deserialize_(data, &array2);