Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: mojo/public/cpp/bindings/lib/string_serialization.cc

Issue 1358353002: * Change C++ serialization/deserialization to not be move-only operations (with the except of |Ha… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: (*it).get() to it->, and other formatting Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/public/cpp/bindings/lib/string_serialization.h ('k') | mojo/public/cpp/bindings/map.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/public/cpp/bindings/lib/string_serialization.h" 5 #include "mojo/public/cpp/bindings/lib/string_serialization.h"
6 6
7 #include <string.h> 7 #include <string.h>
8 8
9 namespace mojo { 9 namespace mojo {
10 10
11 size_t GetSerializedSize_(const String& input) { 11 size_t GetSerializedSize_(const String& input) {
12 if (!input) 12 if (!input)
13 return 0; 13 return 0;
14 return internal::Align(sizeof(internal::String_Data) + input.size()); 14 return internal::Align(sizeof(internal::String_Data) + input.size());
15 } 15 }
16 16
17 void Serialize_(const String& input, 17 void SerializeString_(const String& input,
18 internal::Buffer* buf, 18 internal::Buffer* buf,
19 internal::String_Data** output) { 19 internal::String_Data** output) {
20 if (input) { 20 if (input) {
21 internal::String_Data* result = 21 internal::String_Data* result =
22 internal::String_Data::New(input.size(), buf); 22 internal::String_Data::New(input.size(), buf);
23 if (result) 23 if (result)
24 memcpy(result->storage(), input.data(), input.size()); 24 memcpy(result->storage(), input.data(), input.size());
25 *output = result; 25 *output = result;
26 } else { 26 } else {
27 *output = nullptr; 27 *output = nullptr;
28 } 28 }
29 } 29 }
30 30
31 void Deserialize_(internal::String_Data* input, String* output) { 31 void Deserialize_(internal::String_Data* input, String* output) {
32 if (input) { 32 if (input) {
33 String result(input->storage(), input->size()); 33 String result(input->storage(), input->size());
34 result.Swap(output); 34 result.Swap(output);
35 } else { 35 } else {
36 output->reset(); 36 output->reset();
37 } 37 }
38 } 38 }
39 39
40 } // namespace mojo 40 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/public/cpp/bindings/lib/string_serialization.h ('k') | mojo/public/cpp/bindings/map.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698