Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: mojo/public/cpp/bindings/lib/control_message_proxy.cc

Issue 1358353002: * Change C++ serialization/deserialization to not be move-only operations (with the except of |Ha… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: (*it).get() to it->, and other formatting Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/public/cpp/bindings/lib/control_message_proxy.h" 5 #include "mojo/public/cpp/bindings/lib/control_message_proxy.h"
6 6
7 #include "mojo/public/cpp/bindings/lib/message_builder.h" 7 #include "mojo/public/cpp/bindings/lib/message_builder.h"
8 #include "mojo/public/cpp/bindings/message.h" 8 #include "mojo/public/cpp/bindings/message.h"
9 #include "mojo/public/cpp/system/macros.h" 9 #include "mojo/public/cpp/system/macros.h"
10 #include "mojo/public/interfaces/bindings/interface_control_messages.mojom.h" 10 #include "mojo/public/interfaces/bindings/interface_control_messages.mojom.h"
(...skipping 15 matching lines...) Expand all
26 RunCallback callback_; 26 RunCallback callback_;
27 MOJO_DISALLOW_COPY_AND_ASSIGN(RunResponseForwardToCallback); 27 MOJO_DISALLOW_COPY_AND_ASSIGN(RunResponseForwardToCallback);
28 }; 28 };
29 29
30 bool RunResponseForwardToCallback::Accept(Message* message) { 30 bool RunResponseForwardToCallback::Accept(Message* message) {
31 RunResponseMessageParams_Data* params = 31 RunResponseMessageParams_Data* params =
32 reinterpret_cast<RunResponseMessageParams_Data*>( 32 reinterpret_cast<RunResponseMessageParams_Data*>(
33 message->mutable_payload()); 33 message->mutable_payload());
34 params->DecodePointersAndHandles(message->mutable_handles()); 34 params->DecodePointersAndHandles(message->mutable_handles());
35 35
36 RunResponseMessageParamsPtr params_ptr; 36 RunResponseMessageParamsPtr params_ptr(RunResponseMessageParams::New());
37 Deserialize_(params, &params_ptr); 37 Deserialize_(params, params_ptr.get());
38 38
39 callback_.Run(params_ptr->query_version_result.Pass()); 39 callback_.Run(params_ptr->query_version_result.Pass());
40 return true; 40 return true;
41 } 41 }
42 42
43 void SendRunMessage(MessageReceiverWithResponder* receiver, 43 void SendRunMessage(MessageReceiverWithResponder* receiver,
44 QueryVersionPtr query_version, 44 QueryVersionPtr query_version,
45 const RunCallback& callback) { 45 const RunCallback& callback) {
46 RunMessageParamsPtr params_ptr(RunMessageParams::New()); 46 RunMessageParamsPtr params_ptr(RunMessageParams::New());
47 params_ptr->reserved0 = 16u; 47 params_ptr->reserved0 = 16u;
48 params_ptr->reserved1 = 0u; 48 params_ptr->reserved1 = 0u;
49 params_ptr->query_version = query_version.Pass(); 49 params_ptr->query_version = query_version.Pass();
50 50
51 size_t size = GetSerializedSize_(params_ptr); 51 size_t size = GetSerializedSize_(*params_ptr);
52 RequestMessageBuilder builder(kRunMessageId, size); 52 RequestMessageBuilder builder(kRunMessageId, size);
53 53
54 RunMessageParams_Data* params = nullptr; 54 RunMessageParams_Data* params = nullptr;
55 Serialize_(params_ptr.Pass(), builder.buffer(), &params); 55 Serialize_(params_ptr.get(), builder.buffer(), &params);
56 params->EncodePointersAndHandles(builder.message()->mutable_handles()); 56 params->EncodePointersAndHandles(builder.message()->mutable_handles());
57 MessageReceiver* responder = new RunResponseForwardToCallback(callback); 57 MessageReceiver* responder = new RunResponseForwardToCallback(callback);
58 if (!receiver->AcceptWithResponder(builder.message(), responder)) 58 if (!receiver->AcceptWithResponder(builder.message(), responder))
59 delete responder; 59 delete responder;
60 } 60 }
61 61
62 void SendRunOrClosePipeMessage(MessageReceiverWithResponder* receiver, 62 void SendRunOrClosePipeMessage(MessageReceiverWithResponder* receiver,
63 RequireVersionPtr require_version) { 63 RequireVersionPtr require_version) {
64 RunOrClosePipeMessageParamsPtr params_ptr(RunOrClosePipeMessageParams::New()); 64 RunOrClosePipeMessageParamsPtr params_ptr(RunOrClosePipeMessageParams::New());
65 params_ptr->reserved0 = 16u; 65 params_ptr->reserved0 = 16u;
66 params_ptr->reserved1 = 0u; 66 params_ptr->reserved1 = 0u;
67 params_ptr->require_version = require_version.Pass(); 67 params_ptr->require_version = require_version.Pass();
68 68
69 size_t size = GetSerializedSize_(params_ptr); 69 size_t size = GetSerializedSize_(*params_ptr);
70 MessageBuilder builder(kRunOrClosePipeMessageId, size); 70 MessageBuilder builder(kRunOrClosePipeMessageId, size);
71 71
72 RunOrClosePipeMessageParams_Data* params = nullptr; 72 RunOrClosePipeMessageParams_Data* params = nullptr;
73 Serialize_(params_ptr.Pass(), builder.buffer(), &params); 73 Serialize_(params_ptr.get(), builder.buffer(), &params);
74 params->EncodePointersAndHandles(builder.message()->mutable_handles()); 74 params->EncodePointersAndHandles(builder.message()->mutable_handles());
75 bool ok = receiver->Accept(builder.message()); 75 bool ok = receiver->Accept(builder.message());
76 MOJO_ALLOW_UNUSED_LOCAL(ok); 76 MOJO_ALLOW_UNUSED_LOCAL(ok);
77 } 77 }
78 78
79 } // namespace 79 } // namespace
80 80
81 ControlMessageProxy::ControlMessageProxy(MessageReceiverWithResponder* receiver) 81 ControlMessageProxy::ControlMessageProxy(MessageReceiverWithResponder* receiver)
82 : receiver_(receiver) { 82 : receiver_(receiver) {
83 } 83 }
84 84
85 void ControlMessageProxy::QueryVersion( 85 void ControlMessageProxy::QueryVersion(
86 const Callback<void(uint32_t)>& callback) { 86 const Callback<void(uint32_t)>& callback) {
87 auto run_callback = [callback](QueryVersionResultPtr query_version_result) { 87 auto run_callback = [callback](QueryVersionResultPtr query_version_result) {
88 callback.Run(query_version_result->version); 88 callback.Run(query_version_result->version);
89 }; 89 };
90 SendRunMessage(receiver_, QueryVersion::New(), run_callback); 90 SendRunMessage(receiver_, QueryVersion::New(), run_callback);
91 } 91 }
92 92
93 void ControlMessageProxy::RequireVersion(uint32_t version) { 93 void ControlMessageProxy::RequireVersion(uint32_t version) {
94 RequireVersionPtr require_version(RequireVersion::New()); 94 RequireVersionPtr require_version(RequireVersion::New());
95 require_version->version = version; 95 require_version->version = version;
96 SendRunOrClosePipeMessage(receiver_, require_version.Pass()); 96 SendRunOrClosePipeMessage(receiver_, require_version.Pass());
97 } 97 }
98 98
99 } // namespace internal 99 } // namespace internal
100 } // namespace mojo 100 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/public/cpp/bindings/lib/control_message_handler.cc ('k') | mojo/public/cpp/bindings/lib/map_internal.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698