Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1682)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_section.css

Issue 1358313004: Settings Rewrite: Make subpage scrolling work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page/settings_section.css
diff --git a/chrome/browser/resources/settings/settings_page/settings_section.css b/chrome/browser/resources/settings/settings_page/settings_section.css
index 6d2622ce538bcb2db77dfeb8d4e0ae4bb715a323..9ed9ebfbdd971ed17da1a6bd2a57d34db2ce7e8d 100644
--- a/chrome/browser/resources/settings/settings_page/settings_section.css
+++ b/chrome/browser/resources/settings/settings_page/settings_section.css
@@ -6,18 +6,52 @@
* @fileoverview
* Common styles for Settings pages.
*/
-#section {
- background-color: white;
+:host {
+ display: block;
+}
+
+:host(.expanded) {
height: 100%;
- margin-bottom: 16px;
- overflow: hidden;
- width: 605px;
+}
+
+:host(.hidden) {
Dan Beam 2015/09/25 00:49:41 why do we need .hidden when we can just use... hid
tommycli 2015/09/25 17:23:22 Done.
+ display: none;
+}
+
+:host(.expanded) #header {
+ display: none;
}
#header .title {
@apply(--paper-font-body2);
}
-#content-container {
+paper-material {
+ background-color: white;
+ box-sizing: border-box;
+ margin-bottom: 16px;
+ overflow: hidden;
padding: 16px;
+ width: 605px;
+}
+
+:host(.neon-animating) paper-material {
+ position: fixed;
+ z-index: 1;
+}
+
+:host(.expanded) paper-material {
+ margin-bottom: 0;
+ min-height: 100%;
+}
+
+#placeholder {
+ margin-bottom: 16px;
Dan Beam 2015/09/25 00:49:41 add a comment that this matches paper-material or
tommycli 2015/09/25 17:23:22 Done.
+ position: absolute;
+ visibility: hidden;
+ width: 100px;
Dan Beam 2015/09/25 00:49:41 why wouldn't we just match the paper-material widt
tommycli 2015/09/25 17:23:22 Done.
+}
+
+:host(.neon-animating) #placeholder {
Dan Beam 2015/09/25 00:49:41 :host(:not(.neon-animating)) #placeholder { posi
tommycli 2015/09/25 17:23:22 Done.
+ position: static;
}

Powered by Google App Engine
This is Rietveld 408576698