chrome/browser/resources/settings/settings_main/settings_main.html - Issue 1358313004: Settings Rewrite: Make subpage scrolling work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 1358313004: Settings Rewrite: Make subpage scrolling work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/settings_main/settings_main.html

diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html

index a207d51c364f87017d73f59ee82c2c0740b296a3..d90d3519d58d783753afc2f6171c26a6eb957597 100644

--- a/chrome/browser/resources/settings/settings_main/settings_main.html

+++ b/chrome/browser/resources/settings/settings_main/settings_main.html

@@ -6,20 +6,18 @@

<dom-module id="cr-settings-main">

- <div id="mainContainer">

- <content select="paper-icon-button"></content>

- <iron-pages id="pageContainer" attr-for-selected="data-route-page"

- selected="[[getSelectedPage_(currentRoute)]]">

- <cr-settings-basic-page data-route-page="basic" prefs="{{prefs}}"

- expand-container="{{expandContainer}}"

- current-route="{{currentRoute}}">

- </cr-settings-basic-page>

- <cr-settings-advanced-page data-route-page="advanced" prefs="{{prefs}}"

- expand-container="{{expandContainer}}"

- current-route="{{currentRoute}}">

- </cr-settings-advanced-page>

- </iron-pages>

- </div>

+ <content select="paper-icon-button"></content>

+ <iron-pages id="pageContainer" attr-for-selected="data-route-page"

+ selected="[[getSelectedPage_(currentRoute)]]">

+ <cr-settings-basic-page data-route-page="basic" prefs="{{prefs}}"

+ expand-container="[[expandContainer]]"

+ current-route="{{currentRoute}}">

+ </cr-settings-basic-page>

+ <cr-settings-advanced-page data-route-page="advanced" prefs="{{prefs}}"

+ expand-container="[[expandContainer]]"

+ current-route="{{currentRoute}}">

+ </cr-settings-advanced-page>

+ </iron-pages>

</template>

</dom-module>