chrome/browser/resources/settings/basic_page/basic_page.html - Issue 1358313004: Settings Rewrite: Make subpage scrolling work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.html

Issue 1358313004: Settings Rewrite: Make subpage scrolling work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/basic_page/basic_page.css ('k') | chrome/browser/resources/settings/settings_main/settings_main.css » ('j') | chrome/browser/resources/settings/settings_page/settings_section.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/basic_page/basic_page.html

diff --git a/chrome/browser/resources/settings/basic_page/basic_page.html b/chrome/browser/resources/settings/basic_page/basic_page.html

index cf64f9ac94ac6180690139d78526e6bb43a22d57..0bf22192dba4d3f2fd097384871fa02e428daf6b 100644

--- a/chrome/browser/resources/settings/basic_page/basic_page.html

+++ b/chrome/browser/resources/settings/basic_page/basic_page.html

@@ -11,24 +11,25 @@

</if>

<dom-module id="cr-settings-basic-page">

+ <link rel="import" type="css" href="basic_page.css">

<cr-settings-section i18n-values="page-title:internetPageTitle"

- expand-container="{{expandContainer}}"

+ expand-container="[[expandContainer]]"

current-route="[[currentRoute]]" section="internet">

<cr-settings-internet-page current-route="{{currentRoute}}">

</cr-settings-internet-page>

</cr-settings-section>

</if>

<cr-settings-section i18n-values="page-title:appearancePageTitle"

- expand-container="{{expandContainer}}"

+ expand-container="[[expandContainer]]"

current-route="[[currentRoute]]" section="appearance">

<cr-settings-appearance-page prefs="{{prefs}}">

</cr-settings-appearance-page>

</cr-settings-section>

<cr-settings-section i18n-values="page-title:onStartup"

- expand-container="{{expandContainer}}"

+ expand-container="[[expandContainer]]"

current-route="[[currentRoute]]" section="on-startup">

<cr-settings-on-startup-page

prefs="{{prefs}}" current-route="{{currentRoute}}">

@@ -36,7 +37,7 @@

</cr-settings-section>

<cr-settings-section i18n-values="page-title:searchPageTitle"

- expand-container="{{expandContainer}}"

+ expand-container="[[expandContainer]]"

current-route="[[currentRoute]]" section="search">

<cr-settings-search-page current-route="{{currentRoute}}">

</cr-settings-search-page>

@@ -44,7 +45,7 @@

<cr-settings-section i18n-values="page-title:usersPageTitle"

- expand-container="{{expandContainer}}"

+ expand-container="[[expandContainer]]"

current-route="[[currentRoute]]" section="users">

<cr-settings-users-page prefs="{{prefs}}"></cr-settings-users-page>

</cr-settings-section>