Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_section.css

Issue 1358313004: Settings Rewrite: Make subpage scrolling work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* Copyright 2015 The Chromium Authors. All rights reserved. 1 /* Copyright 2015 The Chromium Authors. All rights reserved.
2 * Use of this source code is governed by a BSD-style license that can be 2 * Use of this source code is governed by a BSD-style license that can be
3 * found in the LICENSE file. */ 3 * found in the LICENSE file. */
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * Common styles for Settings pages. 7 * Common styles for Settings pages.
8 */ 8 */
9 #section { 9 :host {
10 background-color: white; 10 display: block;
11 }
12
13 :host(.expanded) {
11 height: 100%; 14 height: 100%;
12 margin-bottom: 16px; 15 }
13 overflow: hidden; 16
14 width: 605px; 17 :host(.hidden) {
Dan Beam 2015/09/25 00:49:41 why do we need .hidden when we can just use... hid
tommycli 2015/09/25 17:23:22 Done.
18 display: none;
19 }
20
21 :host(.expanded) #header {
22 display: none;
15 } 23 }
16 24
17 #header .title { 25 #header .title {
18 @apply(--paper-font-body2); 26 @apply(--paper-font-body2);
19 } 27 }
20 28
21 #content-container { 29 paper-material {
30 background-color: white;
31 box-sizing: border-box;
32 margin-bottom: 16px;
33 overflow: hidden;
22 padding: 16px; 34 padding: 16px;
35 width: 605px;
23 } 36 }
37
38 :host(.neon-animating) paper-material {
39 position: fixed;
40 z-index: 1;
41 }
42
43 :host(.expanded) paper-material {
44 margin-bottom: 0;
45 min-height: 100%;
46 }
47
48 #placeholder {
49 margin-bottom: 16px;
Dan Beam 2015/09/25 00:49:41 add a comment that this matches paper-material or
tommycli 2015/09/25 17:23:22 Done.
50 position: absolute;
51 visibility: hidden;
52 width: 100px;
Dan Beam 2015/09/25 00:49:41 why wouldn't we just match the paper-material widt
tommycli 2015/09/25 17:23:22 Done.
53 }
54
55 :host(.neon-animating) #placeholder {
Dan Beam 2015/09/25 00:49:41 :host(:not(.neon-animating)) #placeholder { posi
tommycli 2015/09/25 17:23:22 Done.
56 position: static;
57 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698