Issue 1358263004: Revert "Merge to master: contention over isolate data slots"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1358263004: Revert "Merge to master: contention over isolate data slots" (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Merge to master: contention over isolate data slots" Reason for revert: embeddertests failed. This reverts commit 70bc04b16646c92f221c5aa56831b01d6ec7c1ca. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3b4382a847b5a7439a3107512dbe54c317108579

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -97 lines)			Patch
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	3 chunks	+5 lines, -18 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	19 chunks	+80 lines, -78 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as 3b4382a847b5a7439a3107512dbe54c317108579 (tree was closed).

5 years, 3 months ago (2015-09-22 22:54:29 UTC) #3

Message was sent while issue was closed.

whomp whomp lgtm