Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: ui/events/gesture_detection/gesture_detector.h

Issue 1358263002: [Android] Support double-tap selection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix contextual search Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/gesture_detection/gesture_detector.h
diff --git a/ui/events/gesture_detection/gesture_detector.h b/ui/events/gesture_detection/gesture_detector.h
index 07e90e138e48d5bf2863ff61748b51da2f1aaa5d..c39eabd40c0a0256ebfdd2acf9094b6fd5dab98b 100644
--- a/ui/events/gesture_detection/gesture_detector.h
+++ b/ui/events/gesture_detection/gesture_detector.h
@@ -69,6 +69,11 @@ class GESTURE_DETECTION_EXPORT GestureDetector {
// Maximum time the second pointer can be active for a two finger tap.
base::TimeDelta two_finger_tap_timeout;
+ // Single tap count repetition length. Defaults to 1 (no repetition count).
+ // Note that when double-tap detection is enabled, the single tap repeat
+ // count will always be 1.
+ int single_tap_repeat_interval;
+
VelocityTracker::Strategy velocity_tracker_strategy;
};
@@ -98,9 +103,9 @@ class GESTURE_DETECTION_EXPORT GestureDetector {
void OnTapTimeout();
void Cancel();
void CancelTaps();
- bool IsConsideredDoubleTap(const MotionEvent& first_down,
- const MotionEvent& first_up,
- const MotionEvent& second_down) const;
+ bool IsRepeatedTap(const MotionEvent& first_down,
+ const MotionEvent& first_up,
+ const MotionEvent& second_down) const;
bool HandleSwipeIfNeeded(const MotionEvent& up, float vx, float vy);
class TimeoutGestureHandler;
@@ -134,6 +139,17 @@ class GESTURE_DETECTION_EXPORT GestureDetector {
// up events). Can only be true if there is a double tap listener attached.
bool is_double_tapping_;
+ // Whether the current ACTION_DOWN event meets the criteria for being a
+ // repeated tap. Note that it will be considered a repeated tap only if the
+ // corresponding ACTION_UP yields a valid tap and double-tap detection is
+ // disabled.
+ bool is_down_candidate_for_repeated_single_tap_;
+
+ // The number of repeated taps in the current sequence, i.e., for the initial
+ // tap this is 0, for the first *repeated* tap 1, etc...
+ int current_single_tap_repeat_count_;
+ int single_tap_repeat_interval_;
+
float last_focus_x_;
float last_focus_y_;
float down_focus_x_;
« no previous file with comments | « ui/events/gesture_detection/gesture_configuration_android.cc ('k') | ui/events/gesture_detection/gesture_detector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698