mac: Remove OSX 10.11 font hack.

mac: Remove OSX 10.11 font hack.

Previously, I added a hack to MatchNSFontFamily to never return the system
font on OSX 10.11, since skia had trouble rendering it. That problem has now
been fixed, so the hack can be removed.

BUG=524646
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202657

[erikchen, 2015-09-22 19:32:59]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2015-09-22 19:32:59]

thakis: Please review.

Note that we will want to wait for the skia role that includes
https://codereview.chromium.org/1344213004/ to land before landing this CL.

[Nico, 2015-09-22 21:37:51]

lgtm, thanks for cleaning this up!

https://codereview.chromium.org/1358253002/diff/1/Source/platform/fonts/mac/F...
File Source/platform/fonts/mac/FontFamilyMatcherMac.mm (right):

https://codereview.chromium.org/1358253002/diff/1/Source/platform/fonts/mac/F...
Source/platform/fonts/mac/FontFamilyMatcherMac.mm:142: // the Layout
Expectations should be updated. http://crbug.com/515836.
since you're currently switching all the webkit bots to the 10.10 sdk, should
this be done soon too?

[erikchen, 2015-09-23 00:28:18]

https://codereview.chromium.org/1358253002/diff/1/Source/platform/fonts/mac/F...
File Source/platform/fonts/mac/FontFamilyMatcherMac.mm (right):

https://codereview.chromium.org/1358253002/diff/1/Source/platform/fonts/mac/F...
Source/platform/fonts/mac/FontFamilyMatcherMac.mm:142: // the Layout
Expectations should be updated. http://crbug.com/515836.
On 2015/09/22 21:37:51, Nico (traveling Tue Sep 22) wrote:
> since you're currently switching all the webkit bots to the 10.10 sdk, should
> this be done soon too?

I'm not particularly keen on updating all of the 10.9 layout expectations. I'd
much rather see something like
https://code.google.com/p/chromium/issues/detail?id=524634#c16. Would you be
okay if we left the comment here?

[Nico, 2015-09-23 00:31:25]

https://codereview.chromium.org/1358253002/diff/1/Source/platform/fonts/mac/F...
File Source/platform/fonts/mac/FontFamilyMatcherMac.mm (right):

https://codereview.chromium.org/1358253002/diff/1/Source/platform/fonts/mac/F...
Source/platform/fonts/mac/FontFamilyMatcherMac.mm:142: // the Layout
Expectations should be updated. http://crbug.com/515836.
On 2015/09/23 00:28:18, erikchen wrote:
> On 2015/09/22 21:37:51, Nico (traveling Tue Sep 22) wrote:
> > since you're currently switching all the webkit bots to the 10.10 sdk,
should
> > this be done soon too?
> 
> I'm not particularly keen on updating all of the 10.9 layout expectations. I'd
> much rather see something like
> https://code.google.com/p/chromium/issues/detail?id=524634#c16. Would you be
> okay if we left the comment here?

Sure.

[erikchen, 2015-09-23 01:04:12]

On 2015/09/23 00:31:25, Nico (traveling Tue Sep 22) wrote:
>
https://codereview.chromium.org/1358253002/diff/1/Source/platform/fonts/mac/F...
> File Source/platform/fonts/mac/FontFamilyMatcherMac.mm (right):
> 
>
https://codereview.chromium.org/1358253002/diff/1/Source/platform/fonts/mac/F...
> Source/platform/fonts/mac/FontFamilyMatcherMac.mm:142: // the Layout
> Expectations should be updated. http://crbug.com/515836.
> On 2015/09/23 00:28:18, erikchen wrote:
> > On 2015/09/22 21:37:51, Nico (traveling Tue Sep 22) wrote:
> > > since you're currently switching all the webkit bots to the 10.10 sdk,
> should
> > > this be done soon too?
> > 
> > I'm not particularly keen on updating all of the 10.9 layout expectations.
I'd
> > much rather see something like
> > https://code.google.com/p/chromium/issues/detail?id=524634#c16. Would you be
> > okay if we left the comment here?
> 
> Sure.

Looks like skia roll has landed: https://codereview.chromium.org/1355363002

[erikchen, 2015-09-23 01:04:15]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-09-23 01:04:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358253002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358253002/1

[commit-bot: I haz the power, 2015-09-23 02:33:19]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202657