Issue 1358243003: Build GN with c++11.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1358243003: Build GN with c++11. (Closed)

Created:
5 years, 3 months ago by tfarina

Modified:
5 years, 2 months ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina, Nico

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Build GN with c++11. GN code does not need GNU extensions to be built like some other Chromium code. BUG=427584 TEST=./tools/gn/bootstrap/bootstrap.py, the manual part still works. R=brettw@chromium.org Committed: https://crrev.com/1f9152a906db2d2b2967a77cbcca5614068c1116 Cr-Commit-Position: refs/heads/master@{#350558}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/gn/bootstrap/bootstrap.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358243003/1

5 years, 2 months ago (2015-09-24 15:22:56 UTC) #4

commit-bot: I haz the power

5 years, 2 months ago (2015-09-24 15:36:59 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1f9152a906db2d2b2967a77cbcca5614068c1116
Cr-Commit-Position: refs/heads/master@{#350558}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages