Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js

Issue 1358203003: Normalize and update the header value checks to RFC 7230 for Fetch Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js b/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js
index 4dd6037237a186f84604b764124bd4815f2e63bb..6dd8fefd0245b7a50cca8f043c173c884db796a8 100644
--- a/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js
+++ b/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js
@@ -176,6 +176,45 @@ test(function() {
assert_equals(headers.get('a'), 'b');
assert_equals(headers.get('c'), 'd');
+ // Tests for new Headers with valid values.
+ headers = new Headers();
+ headers.append('a', '\xd0\xa1');
+ assert_equals(headers.get('a'), '\xd0\xa1');
+ headers.append('b', 't t');
+ assert_equals(headers.get('b'), 't t');
+ headers.append('c', 't\tt');
+ assert_equals(headers.get('c'), 't\tt');
+ headers.append('k', '');
+ assert_equals(headers.get('k'), '');
+ headers.append('l', ' ');
+ assert_equals(headers.get('l'), '');
+ headers.append('m', '\r\n\r\n\r\n');
+ assert_equals(headers.get('m'), '');
+
+ headers.set('n', '\xd0\xa1');
+ assert_equals(headers.get('n'), '\xd0\xa1');
+ headers.set('o', '');
+ assert_equals(headers.get('o'), '');
+ headers.set('p', '\r\n\r\n\r\n\r\t');
+ assert_equals(headers.get('p'), '');
+
+ // Tests for normalizing header values.
+ headers.append('d', ' t');
+ assert_equals(headers.get('d'), 't');
+ headers.append('e', 't ');
+ assert_equals(headers.get('e'), 't');
+ headers.append('f', ' t ');
+ assert_equals(headers.get('f'), 't');
+ headers.append('g', 'test\r');
+ assert_equals(headers.get('g'), 'test');
+
+ headers.set('h', 'test\n');
+ assert_equals(headers.get('h'), 'test');
+ headers.set('i', 'test\r\n');
+ assert_equals(headers.get('i'), 'test');
+ headers.set('j', 'test\t');
+ assert_equals(headers.get('j'), 'test');
+
// Throw errors
INVALID_HEADER_NAMES.forEach(function(name) {
assert_throws({name: 'TypeError'},

Powered by Google App Engine
This is Rietveld 408576698