Normalize and update the header value checks to RFC 7230 for Fetch

third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js

 if (self.importScripts) {
   importScripts('../resources/fetch-test-helpers.js');
 }
 
 test(function() {
     var expectedValueMap = {
       'content-language': 'ja',
       'content-type': 'text/html; charset=UTF-8',
       'x-fetch-test': 'response test field'
     };
@@ skipping 158 matching lines @@
     headers.set('a', 'x');
     assert_equals(headers.get('a'), 'x');
     assert_equals(headers2.get('a'), 'b');
 
     // new Headers with Dictionary
     headers = new Headers({'a': 'b', 'c': 'd'});
     assert_equals(size(headers), 2, 'headers size should match');
     assert_equals(headers.get('a'), 'b');
     assert_equals(headers.get('c'), 'd');
 
+    // Tests for new valid Headers values.

[tyoshino (SeeGerritForStatus), 2015/09/28 08:11:58]

Tests for new Headers with valid values.

[shiva.jm, 2015/09/28 08:56:44]

Done.

+    headers = new Headers();
+    headers.set('a', '\xd0\xa1');

[tyoshino (SeeGerritForStatus), 2015/09/28 06:35:39]

why is set() used for some of the and is append() used for the others?

[shiva.jm, 2015/09/28 07:01:21]

Normalizing and updating the header value checks are done for both
Headers::append()
and Headers::set(), so tested for both apis.

[tyoshino (SeeGerritForStatus), 2015/09/28 08:11:58]

I see. It's good to check both. But when I read this test, I guessed that the
choice of the method at certain position in this sequence is meaningful for
checking some behavior.

I suggest that we
- check both set() and append() for all test cases (I think it's too much), or
- check only either of them for all test cases, and the other for a few of them,
or
- please explain that you included some set() calls in them randomly to check
set(), too, in the comment at L179.

+    assert_equals(headers.get('a'), '\xd0\xa1');
+    headers.append('b', 't t');
+    assert_equals(headers.get('b'), 't t');
+    headers.append('c', 't\tt');
+    assert_equals(headers.get('c'), 't\tt');
+    headers.set('k', '');
+    assert_equals(headers.get('k'), '');
+    headers.append('l', ' ');
+    assert_equals(headers.get('l'), '');
+    headers.append('m', '\r\n\r\n\r\n');
+    assert_equals(headers.get('m'), '');
+
+    // Tests for normalizing header values.
+    headers.append('d', ' t');
+    assert_equals(headers.get('d'), 't');
+    headers.set('e', 't ');
+    assert_equals(headers.get('d'), 't');

[tyoshino (SeeGerritForStatus), 2015/09/28 06:35:39]

get('e')

[shiva.jm, 2015/09/28 07:01:21]

Done.

+    headers.append('f', ' t ');
+    assert_equals(headers.get('f'), 't');
+    headers.append('g', 'test\r');
+    assert_equals(headers.get('g'), 'test');
+    headers.set('h', 'test\n');
+    assert_equals(headers.get('h'), 'test');
+    headers.append('i', 'test\r\n');
+    assert_equals(headers.get('i'), 'test');
+    headers.append('j', 'test\t');
+    assert_equals(headers.get('j'), 'test');
+
     // Throw errors
     INVALID_HEADER_NAMES.forEach(function(name) {
         assert_throws({name: 'TypeError'},
                       function() {
                         var obj = {};
                         obj[name] = 'a';
                         var headers = new Headers(obj);
                       },
                       'new Headers with an invalid name (' + name +
                       ') should throw');
@@ skipping 26 matching lines @@
                   'new Headers with a sequence with less than two strings ' +
                   'should throw');
     assert_throws({name: 'TypeError'},
                   function() { var headers = new Headers([['a', 'b'],
                                                           ['x', 'y', 'z']]); },
                   'new Headers with a sequence with more than two strings ' +
                   'should throw');
   }, 'Headers');
 
 done();