Simplify the transport dib situation across our various platforms, as a

Simplify the transport dib situation across our various platforms, as a
pre-cursor to moving Chrome OS + Aura away from legacy GTK+X11 dibs. Now, we
have just:
- Windows style dibs
- POSIX style dibs
- Legacy GTK+X11 style dibs.

There's some ifdef hoops that will be removed in a follow-up CL when
Chrome OS + Aura will be moved away from legacy GTK+X11 dibs and on to POSIX
dibs.

BUG=147622
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192629

[Chris Evans, 2013-04-03 23:09:36]

Cleanup dibs prior to rework of Aura dib story.

[Ken Russell (switch to Gerrit), 2013-04-04 00:26:45]

https://codereview.chromium.org/13582008/diff/7001/ui/surface/transport_dib_p...
File ui/surface/transport_dib_posix.cc (right):

https://codereview.chromium.org/13582008/diff/7001/ui/surface/transport_dib_p...
ui/surface/transport_dib_posix.cc:13: #include "transport_dib_gtk.cc"
That's gross -- is there a timeframe for cleaning this up?

Is there another way of handling this? Maybe explicitly calling it
transport_dib_sysv.cc and conditionally #ifdef'ing out the implementation?

[Chris Evans, 2013-04-04 01:34:45]

On 2013/04/04 00:26:45, kbr wrote:
>
https://codereview.chromium.org/13582008/diff/7001/ui/surface/transport_dib_p...
> File ui/surface/transport_dib_posix.cc (right):
> 
>
https://codereview.chromium.org/13582008/diff/7001/ui/surface/transport_dib_p...
> ui/surface/transport_dib_posix.cc:13: #include "transport_dib_gtk.cc"
> That's gross -- is there a timeframe for cleaning this up?

Yeah, immediately in a follow-up CL, however:

> Is there another way of handling this? Maybe explicitly calling it
> transport_dib_sysv.cc and conditionally #ifdef'ing out the implementation?

I do prefer this, so I've done it. Thanks.

I just uploaded another CL which:
- Does the less ugly include thing.
- Fixes a couple of lint errors.
- Adds a tweak so that "Android" is closer to a strict no-op in terms of this
change. This re-adds a slight divergence between "Android" and "POSIX", but the
implementations are at least now shared apart from a small ifdef for the
difference.
(I will look to fully reconcile Android and POSIX, as a matter of cleanliness,
in a follow-up CL. For now, I'm trying to keep this CL as small and as likely to
stick as possible!)

PTAL! Thanks!

[Ken Russell (switch to Gerrit), 2013-04-04 18:52:12]

lgtm

https://codereview.chromium.org/13582008/diff/28001/ui/surface/transport_dib_...
File ui/surface/transport_dib_posix.cc (right):

https://codereview.chromium.org/13582008/diff/28001/ui/surface/transport_dib_...
ui/surface/transport_dib_posix.cc:111: #endif
Comment which #ifdef this matches since it's so far away.

https://codereview.chromium.org/13582008/diff/28001/ui/surface/transport_dib_...
File ui/surface/transport_dib_sysvipc.cc (right):

https://codereview.chromium.org/13582008/diff/28001/ui/surface/transport_dib_...
ui/surface/transport_dib_sysvipc.cc:7: #if defined(TOOLKIT_GTK) ||
(defined(OS_LINUX) && defined(USE_AURA))
Consider adding the same comment you did to transport_dib_posix.cc.

[Chris Evans, 2013-04-05 01:17:29]

On 2013/04/04 18:52:12, kbr wrote:
> lgtm
> 
>
https://codereview.chromium.org/13582008/diff/28001/ui/surface/transport_dib_...
> File ui/surface/transport_dib_posix.cc (right):
> 
>
https://codereview.chromium.org/13582008/diff/28001/ui/surface/transport_dib_...
> ui/surface/transport_dib_posix.cc:111: #endif
> Comment which #ifdef this matches since it's so far away.
> 
>
https://codereview.chromium.org/13582008/diff/28001/ui/surface/transport_dib_...
> File ui/surface/transport_dib_sysvipc.cc (right):
> 
>
https://codereview.chromium.org/13582008/diff/28001/ui/surface/transport_dib_...
> ui/surface/transport_dib_sysvipc.cc:7: #if defined(TOOLKIT_GTK) ||
> (defined(OS_LINUX) && defined(USE_AURA))
> Consider adding the same comment you did to transport_dib_posix.cc.

Done / done, thx.

[Ken Russell (switch to Gerrit), 2013-04-05 20:45:54]

Still LGTM.

[Chris Evans, 2013-04-05 20:50:44]

Committed patchset #6 manually as r192629 (presubmit successful).