Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.h

Issue 1358173008: Add UMA stats for pinch-zoom behavior on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Small build fix to previous patch Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/VisualViewport.h
diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.h b/third_party/WebKit/Source/core/frame/VisualViewport.h
index e95eae3853d82bd45e1a2ba7c1fe5fea14aa65a4..fbd35f59db2425321f19c5fb11b7035e5def7c8c 100644
--- a/third_party/WebKit/Source/core/frame/VisualViewport.h
+++ b/third_party/WebKit/Source/core/frame/VisualViewport.h
@@ -195,6 +195,15 @@ public:
GraphicsLayer* layerForHorizontalScrollbar() const override;
GraphicsLayer* layerForVerticalScrollbar() const override;
+ // Used for gathering data on user pinch-zoom statistics.
+ void userDidChangeScale();
+ void sendUMAMetrics();
+ void startTrackingPinchStats();
+
+ // Heuristic-based function for determining if we should disable workarounds
+ // for viewing websites that are not optimized for mobile devices.
+ bool shouldDisableDesktopWorkarounds() const;
+
private:
explicit VisualViewport(FrameHost&);
@@ -231,6 +240,8 @@ private:
float m_scale;
IntSize m_size;
float m_topControlsAdjustment;
+ float m_maxPageScale;
+ bool m_trackPinchZoomStatsForPage;
};
} // namespace blink
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/VisualViewport.cpp » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698