Issue 1358163003: Merge to XFA: Change nonstd::unique_ptr to take a custom deleter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1358163003: Merge to XFA: Change nonstd::unique_ptr to take a custom deleter. (Closed)

Created:
5 years, 3 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Change nonstd::unique_ptr to take a custom deleter. Code is mostly stolen from Chromium's scoped_ptr. - Add unit tests. - Use this to fix a leak. BUG=chromium:531408 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1351383004 . (cherry picked from commit cef2a9c51bee4b987fc813013d45dad6535a9a46) Committed: https://pdfium.googlesource.com/pdfium/+/13fe8c9d74607610b3a535c7edf911eaa8711318

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+587 lines, -99 lines)			Patch
M	BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/include/fxcrt/fx_basic.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	third_party/base/nonstd_unique_ptr.h	View	4 chunks	+226 lines, -95 lines	0 comments	Download
M	third_party/base/nonstd_unique_ptr_unittest.cpp	View	1 chunk	+303 lines, -0 lines	0 comments	Download
M	third_party/base/template_util.h	View	2 chunks	+45 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

Committed patchset #1 (id:1) manually as 13fe8c9d74607610b3a535c7edf911eaa8711318 (presubmit successful).

5 years, 3 months ago (2015-09-23 04:53:27 UTC) #2

Message was sent while issue was closed.

lgtm