content/browser/frame_host/navigator_impl.cc - Issue 1358153002: Issue AboutToNavigateRenderFrame notification after beforeunload handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1358153002: Issue AboutToNavigateRenderFrame notification after beforeunload handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index 53417fc3adacec03cb632be18610979ae65f0956..786fcc7ba1a259d4b15c01987fea56b38f52af30 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -314,7 +314,7 @@ bool NavigatorImpl::NavigateToEntry(

CheckWebUIRendererDoesNotDisplayNormalURL(dest_render_frame_host, dest_url);

// Notify observers that we will navigate in this RenderFrame.

- if (delegate_) {

+ if (delegate_ && !dest_render_frame_host->are_navigations_suspended()) {

delegate_->AboutToNavigateRenderFrame(frame_tree_node->current_frame_host(),

yurys 2015/09/22 19:31:43 Should we move this call closer to the two places

dest_render_frame_host);

}

« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »