Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135813002: Revert of Merge NativeTextfieldViews into views::Textfield. (Closed)

Created:
6 years, 11 months ago by msw
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su, Evan Stade, Dan Beam, dmazzoni, oshima, Alexei Svitkine (slow), varunjain, yukawa, Peter Kasting, Yuki, ckocagil
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/120503005/ Reason for revert: views_unittest failures... :-( TBR=sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=131660 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4845 lines, -3853 lines) Patch
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/autofill/decorated_textfield.h View 3 chunks +18 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/autofill/decorated_textfield.cc View 6 chunks +56 lines, -40 lines 0 comments Download
A chrome/browser/ui/views/autofill/decorated_textfield_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/cookie_info_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 8 chunks +57 lines, -57 lines 0 comments Download
M chrome/browser/ui/views/password_generation_bubble_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/folder_header_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/app_list/views/search_box_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/touch/touch_editing_controller.h View 1 chunk +1 line, -1 line 0 comments Download
A ui/views/controls/textfield/native_textfield_views.h View 1 chunk +397 lines, -0 lines 0 comments Download
A ui/views/controls/textfield/native_textfield_views.cc View 1 chunk +1528 lines, -0 lines 0 comments Download
A ui/views/controls/textfield/native_textfield_views_unittest.cc View 1 chunk +2000 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 9 chunks +112 lines, -211 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 14 chunks +234 lines, -1213 lines 0 comments Download
M ui/views/controls/textfield/textfield_controller.h View 1 chunk +20 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield_controller.cc View 1 chunk +16 lines, -0 lines 0 comments Download
D ui/views/controls/textfield/textfield_unittest.cc View 1 chunk +0 lines, -1966 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model.h View 7 chunks +31 lines, -27 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model.cc View 20 chunks +52 lines, -49 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model_unittest.cc View 31 chunks +232 lines, -226 lines 0 comments Download
M ui/views/ime/input_method_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 18 chunks +33 lines, -28 lines 0 comments Download
M ui/views/view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/widget/widget.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
msw
Created Revert of Merge NativeTextfieldViews into views::Textfield.
6 years, 11 months ago (2014-01-12 00:52:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/135813002/1
6 years, 11 months ago (2014-01-12 00:52:44 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-12 00:53:21 UTC) #3
Message was sent while issue was closed. 
Change committed as 244402

Powered by Google App Engine
This is Rietveld 408576698