Issue 1358123002: Remove shouldPersist from WebPlugin.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1358123002: Remove shouldPersist from WebPlugin.h. (Closed)

Created:
5 years, 3 months ago by dsinclair

Modified:
5 years, 3 months ago

Reviewers:
chrishtr, wjmaclean

CC:
blink-reviews, dglazkov+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove shouldPersist from WebPlugin.h. The only caller of shouldPersist was removed in r201401. This removes the method from the WebPlugin API. BUG=370459 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202635

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	public/web/WebPlugin.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dsinclair

PTAL. wjmaclean@ for the change. chrishtr@ for public/web OWNERS.

5 years, 3 months ago (2015-09-22 15:10:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358123002/1

5 years, 3 months ago (2015-09-22 15:51:04 UTC) #6

commit-bot: I haz the power

5 years, 3 months ago (2015-09-22 16:36:39 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202635

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages