Issue 13581003: Make GrIODB record and play back copySurface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13581003: Make GrIODB record and play back copySurface. (Closed)

Created:
7 years, 8 months ago by bsalomon

Modified:
7 years, 8 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make GrIODB record and play back copySurface. Committed: https://code.google.com/p/skia/source/detail?r=8574

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -40 lines)			Patch
M	src/gpu/GrDrawTarget.h	View	2 chunks	+12 lines, -4 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View	3 chunks	+75 lines, -30 lines	2 comments	Download
M	src/gpu/GrInOrderDrawBuffer.h	View	9 chunks	+26 lines, -6 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	6 chunks	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 question https://codereview.chromium.org/13581003/diff/1/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp (right): https://codereview.chromium.org/13581003/diff/1/src/gpu/GrDrawTarget.cpp#newcode755 src/gpu/GrDrawTarget.cpp:755: // returns true if the ...

7 years, 8 months ago (2013-04-03 21:18:43 UTC) #2

bsalomon

Committed patchset #1 manually as r8574 (presubmit successful).

7 years, 8 months ago (2013-04-09 15:38:27 UTC) #3

bsalomon

7 years, 8 months ago (2013-04-09 15:47:42 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/13581003/diff/1/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/13581003/diff/1/src/gpu/GrDrawTarget.cpp#newc...
src/gpu/GrDrawTarget.cpp:755: // returns true if the read/written rect
intersects the src/dst and false if not.
On 2013/04/03 21:18:43, robertphillips wrote:
> surely dst & src can be const here?

Done.

Expand Messages | Collapse Messages