Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1358063005: PPC: [ic] Also collect known map for relational comparison. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [ic] Also collect known map for relational comparison. Port e56f265f6d41fadbcea2be65d9b573bad8b4709d Original commit message: Previously we only collected the known map for equality comparisons. But if we also collect it for relational comparisons, we can inline a fast path of ToPrimitive on the objects, which is especially interesting since both sides have the same map. For now we only inline a very limited subset of ToPrimitive in Crankshaft, which is when the receiver map (and its prototype chain) doesn't have @@toPrimitive, and both valueOf and toString are the default versions on the %ObjectPrototype%. In this case the relational comparison would reduce to a string comparison of "[object CLASS]" with itself and so we can reduce that to a boolean constant plus map checks on both left and right hand side, plus code dependencies on the prototype chain. This repairs the regression on box2d. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=chromium:534200 LOG=n Committed: https://crrev.com/394f3cf3ebf3cd5c028d6bf8041ebe4c33d949ad Cr-Commit-Position: refs/heads/master@{#30869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years, 3 months ago (2015-09-22 18:50:02 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358063005/1
5 years, 3 months ago (2015-09-22 18:50:28 UTC) #3
michael_dawson
On 2015/09/22 18:50:28, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 3 months ago (2015-09-22 18:55:47 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-22 19:16:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358063005/1
5 years, 3 months ago (2015-09-22 19:18:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 19:19:57 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 19:20:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/394f3cf3ebf3cd5c028d6bf8041ebe4c33d949ad
Cr-Commit-Position: refs/heads/master@{#30869}

Powered by Google App Engine
This is Rietveld 408576698