Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: content/child/background_sync/background_sync_provider.h

Issue 1358063004: Use mojo to connect to BackgroundSyncManager object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix crash in HasWindowProviderHost Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/background_sync/background_sync_provider.h
diff --git a/content/child/background_sync/background_sync_provider.h b/content/child/background_sync/background_sync_provider.h
index cb4f6af5dcf34c8431f89f19d8b718f42f2adb20..66460cfcffe2d3f27c0f0552eda7d04e097f3eca 100644
--- a/content/child/background_sync/background_sync_provider.h
+++ b/content/child/background_sync/background_sync_provider.h
@@ -8,25 +8,39 @@
#include <string>
#include "base/memory/scoped_ptr.h"
-#include "content/child/worker_task_runner.h"
#include "content/common/background_sync_service.mojom.h"
+#include "content/public/child/worker_thread.h"
#include "third_party/WebKit/public/platform/modules/background_sync/WebSyncProvider.h"
-namespace content {
+namespace base {
+class SingleThreadTaskRunner;
+}
-class ServiceRegistry;
+namespace content {
// The BackgroundSyncProvider is called by the SyncManager and SyncRegistration
// objects (and their Periodic counterparts) and communicates with the
-// BackgroundSyncManager object in the browser process. This class is
-// instantiated on the main thread by BlinkPlatformImpl, and its methods can be
-// called directly from the main thread.
-class BackgroundSyncProvider : public blink::WebSyncProvider {
+// BackgroundSyncManager object in the browser process. Each thread will have
+// its own instance (e.g. main thread, worker threads), instantiated as needed
+// by BlinkPlatformImpl. Each instance of the provider creates a new mojo
+// connection to a new BackgroundSyncManagerImpl, which then talks to the
+// BackgroundSyncManager object.
+class BackgroundSyncProvider : public blink::WebSyncProvider,
+ public WorkerThread::Observer {
public:
- explicit BackgroundSyncProvider(ServiceRegistry* service_registry);
+ // Constructor made public to allow BlinkPlatformImpl to own a copy for the
+ // main thread. Everyone else should use GetOrCreateThreadSpecificInstance().
+ explicit BackgroundSyncProvider(
+ const scoped_refptr<base::SingleThreadTaskRunner> main_task_runner);
~BackgroundSyncProvider() override;
+ // Returns thread-specific instance (if exists). Otherwise, a new instance
+ // will be created for the thread, except when called for a worker thread that
+ // has already been stopped.
+ static BackgroundSyncProvider* GetOrCreateThreadSpecificInstance(
+ base::SingleThreadTaskRunner* main_thread_task_runner);
+
// blink::WebSyncProvider implementation
void registerBackgroundSync(
const blink::WebSyncRegistration* options,
@@ -61,6 +75,9 @@ class BackgroundSyncProvider : public blink::WebSyncProvider {
const BackgroundSyncService::DuplicateRegistrationHandleCallback&
callback);
+ // WorkerThread::Observer implementation.
+ void WillStopCurrentWorkerThread() override;
+
private:
// Callback handlers
void RegisterCallback(
@@ -90,8 +107,8 @@ class BackgroundSyncProvider : public blink::WebSyncProvider {
// Helper method that returns an initialized BackgroundSyncServicePtr.
BackgroundSyncServicePtr& GetBackgroundSyncServicePtr();
- ServiceRegistry* service_registry_;
BackgroundSyncServicePtr background_sync_service_;
+ scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner_;
DISALLOW_COPY_AND_ASSIGN(BackgroundSyncProvider);
};

Powered by Google App Engine
This is Rietveld 408576698