Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4020)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 1358063002: Switch warning_explanations (yellow) to be unauthenticated_explanations (neutral). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index 43a21db92f901632ef5e79170cafe7221805aa74..abe81b3f9e854177c23617011d718c7871c98e27 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -395,7 +395,7 @@ void CheckBrokenSecurityStyle(const SecurityStyleTestObserver& observer,
const content::SecurityStyleExplanations& expired_explanation =
observer.latest_explanations();
- EXPECT_EQ(0u, expired_explanation.warning_explanations.size());
+ EXPECT_EQ(0u, expired_explanation.unauthenticated_explanations.size());
ASSERT_EQ(1u, expired_explanation.broken_explanations.size());
// Check that the summary and description are as expected.
@@ -2962,7 +2962,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, SecurityStyleChangedObserver) {
ui_test_utils::NavigateToURL(browser(), http_url);
EXPECT_EQ(content::SECURITY_STYLE_UNAUTHENTICATED,
observer.latest_security_style());
- EXPECT_EQ(0u, observer.latest_explanations().warning_explanations.size());
+ EXPECT_EQ(0u,
+ observer.latest_explanations().unauthenticated_explanations.size());
EXPECT_EQ(0u, observer.latest_explanations().broken_explanations.size());
EXPECT_EQ(0u, observer.latest_explanations().secure_explanations.size());
EXPECT_FALSE(observer.latest_explanations().scheme_is_cryptographic);
@@ -2982,7 +2983,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, SecurityStyleChangedObserver) {
const content::SecurityStyleExplanations& mixed_content_explanation =
observer.latest_explanations();
- ASSERT_EQ(0u, mixed_content_explanation.warning_explanations.size());
+ ASSERT_EQ(0u, mixed_content_explanation.unauthenticated_explanations.size());
ASSERT_EQ(0u, mixed_content_explanation.broken_explanations.size());
CheckSecureExplanations(mixed_content_explanation.secure_explanations,
VALID_CERTIFICATE, browser());
@@ -3015,7 +3016,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, SecurityStyleChangedObserver) {
ui_test_utils::NavigateToURL(browser(), valid_https_url);
EXPECT_EQ(content::SECURITY_STYLE_AUTHENTICATED,
observer.latest_security_style());
- EXPECT_EQ(0u, observer.latest_explanations().warning_explanations.size());
+ EXPECT_EQ(0u,
+ observer.latest_explanations().unauthenticated_explanations.size());
EXPECT_EQ(0u, observer.latest_explanations().broken_explanations.size());
CheckSecureExplanations(observer.latest_explanations().secure_explanations,
VALID_CERTIFICATE, browser());
@@ -3080,7 +3082,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, SecurityStyleChangedObserverGoBack) {
ui_test_utils::NavigateToURL(browser(), valid_https_url);
EXPECT_EQ(content::SECURITY_STYLE_AUTHENTICATED,
observer.latest_security_style());
- EXPECT_EQ(0u, observer.latest_explanations().warning_explanations.size());
+ EXPECT_EQ(0u,
+ observer.latest_explanations().unauthenticated_explanations.size());
EXPECT_EQ(0u, observer.latest_explanations().broken_explanations.size());
CheckSecureExplanations(observer.latest_explanations().secure_explanations,
VALID_CERTIFICATE, browser());
@@ -3120,7 +3123,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, SecurityStyleChangedObserverGoBack) {
EXPECT_EQ(content::SECURITY_STYLE_AUTHENTICATED,
observer.latest_security_style());
- EXPECT_EQ(0u, observer.latest_explanations().warning_explanations.size());
+ EXPECT_EQ(0u,
+ observer.latest_explanations().unauthenticated_explanations.size());
EXPECT_EQ(0u, observer.latest_explanations().broken_explanations.size());
CheckSecureExplanations(observer.latest_explanations().secure_explanations,
VALID_CERTIFICATE, browser());

Powered by Google App Engine
This is Rietveld 408576698