Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 1358063002: Switch warning_explanations (yellow) to be unauthenticated_explanations (neutral). (Closed)

Created:
5 years, 3 months ago by lgarron
Modified:
5 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch warning_explanations (yellow) to be unauthenticated_explanations (neutral). BUG=534681 Committed: https://crrev.com/8555a6c0f5a20b3409de73b7b120d5701b4668b2 Cr-Commit-Position: refs/heads/master@{#360489}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M chrome/browser/ui/browser.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 6 chunks +10 lines, -6 lines 0 comments Download
M content/browser/devtools/protocol/security_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/security_style_explanations.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (8 generated)
lgarron
estark@: I've had this hanging around for a while. The per-request data has been sending ...
5 years, 1 month ago (2015-11-06 21:59:27 UTC) #2
estark
lgtm
5 years, 1 month ago (2015-11-07 01:46:50 UTC) #3
lgarron
pkasting@, could you review chrome/browser/ui (2 files)? pfeldman@, could you review the other two files?
5 years, 1 month ago (2015-11-07 01:51:34 UTC) #5
Peter Kasting
LGTM https://codereview.chromium.org/1358063002/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): https://codereview.chromium.org/1358063002/diff/1/chrome/browser/ui/browser.cc#newcode1385 chrome/browser/ui/browser.cc:1385: if (net::IsCertStatusMinorError(security_info.cert_status)) Nit: This now needs {}
5 years, 1 month ago (2015-11-07 02:33:18 UTC) #6
pfeldman
devtools lgtm
5 years, 1 month ago (2015-11-09 23:01:33 UTC) #7
estark
Hey Lucas are you waiting on anything to land this?
5 years, 1 month ago (2015-11-18 22:09:51 UTC) #8
lgarron
On 2015/11/18 at 22:09:51, estark wrote: > Hey Lucas are you waiting on anything to ...
5 years, 1 month ago (2015-11-18 22:11:35 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358063002/1
5 years, 1 month ago (2015-11-18 22:13:02 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/125001) mac_chromium_gn_rel on ...
5 years, 1 month ago (2015-11-18 22:16:11 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358063002/20001
5 years, 1 month ago (2015-11-18 23:19:58 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 01:32:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358063002/20001
5 years, 1 month ago (2015-11-19 01:40:50 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 02:20:33 UTC) #21
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 02:21:34 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8555a6c0f5a20b3409de73b7b120d5701b4668b2
Cr-Commit-Position: refs/heads/master@{#360489}

Powered by Google App Engine
This is Rietveld 408576698