Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1358033002: iOS Web Shell: Implemented warning dialog for invalid SSL certs. (Closed)

Created:
5 years, 3 months ago by Eugene But (OOO till 7-30)
Modified:
5 years, 2 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

iOS Web Shell: Implemented warning dialog for invalid SSL certs. This change is needed for testing recoverable SSL interstitials for WKWebView. BUG=462427 Committed: https://crrev.com/994fa73166f61659a46bfbe51080370a6fb5f24b Cr-Commit-Position: refs/heads/master@{#351177}

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/Cancel/Go Back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M ios/web/shell/view_controller.mm View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Eugene But (OOO till 7-30)
5 years, 3 months ago (2015-09-21 22:44:49 UTC) #2
Eugene But (OOO till 7-30)
Ping
5 years, 3 months ago (2015-09-24 17:38:41 UTC) #3
Eugene But (OOO till 7-30)
I guess Rohit is busy, but I don't think this CL actually needs his review. ...
5 years, 2 months ago (2015-09-25 18:24:42 UTC) #5
kkhorimoto
lgtm https://codereview.chromium.org/1358033002/diff/1/ios/web/shell/view_controller.mm File ios/web/shell/view_controller.mm (right): https://codereview.chromium.org/1358033002/diff/1/ios/web/shell/view_controller.mm#newcode305 ios/web/shell/view_controller.mm:305: [alert addAction:[UIAlertAction actionWithTitle:@"Cancel" s/Cancel/Go Back
5 years, 2 months ago (2015-09-28 21:49:58 UTC) #7
Eugene But (OOO till 7-30)
Thanks! https://codereview.chromium.org/1358033002/diff/1/ios/web/shell/view_controller.mm File ios/web/shell/view_controller.mm (right): https://codereview.chromium.org/1358033002/diff/1/ios/web/shell/view_controller.mm#newcode305 ios/web/shell/view_controller.mm:305: [alert addAction:[UIAlertAction actionWithTitle:@"Cancel" On 2015/09/28 21:49:58, kkhorimoto_ wrote: ...
5 years, 2 months ago (2015-09-28 22:11:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358033002/20001
5 years, 2 months ago (2015-09-28 22:13:13 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 22:40:04 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 22:41:30 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/994fa73166f61659a46bfbe51080370a6fb5f24b
Cr-Commit-Position: refs/heads/master@{#351177}

Powered by Google App Engine
This is Rietveld 408576698