Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: remoting/test/app_remoting_service_urls.cc

Issue 1357973002: Removing Test and Staging environments from App Remoting Test Driver tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing unittest Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/test/app_remoting_service_urls.h ('k') | remoting/test/app_remoting_test_driver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/test/app_remoting_service_urls.cc
diff --git a/remoting/test/app_remoting_service_urls.cc b/remoting/test/app_remoting_service_urls.cc
index 87432a60cdee8f030894a9beaf83d5494d4dba46..a787cfad2602354641b3158814ac74b8f1fc94a7 100644
--- a/remoting/test/app_remoting_service_urls.cc
+++ b/remoting/test/app_remoting_service_urls.cc
@@ -13,8 +13,6 @@ namespace {
const char kAppRemotingTestEndpointBase[] =
"https://www-googleapis-test.sandbox.google.com/appremoting/%s";
const char kAppRemotingDevEndpointQualifier[] = "v1beta1_dev";
-const char kAppRemotingTestEndpointQualifier[] = "v1beta1";
-const char kAppRemotingStagingEndpointQualifier[] = "v1beta1_staging";
// Placeholder value is for the Application ID.
const char kRunApplicationApi[] = "applications/%s/run";
@@ -35,27 +33,9 @@ bool IsSupportedServiceEnvironment(ServiceEnvironment service_environment) {
std::string GetBaseUrl(ServiceEnvironment service_environment) {
std::string base_service_url;
- const char* environment_qualifier = nullptr;
- switch (service_environment) {
- case kDeveloperEnvironment:
- environment_qualifier = kAppRemotingDevEndpointQualifier;
- break;
-
- case kTestingEnvironment:
- environment_qualifier = kAppRemotingTestEndpointQualifier;
- break;
-
- case kStagingEnvironment:
- environment_qualifier = kAppRemotingStagingEndpointQualifier;
- break;
-
- default:
- NOTREACHED();
- }
-
- if (environment_qualifier) {
- base_service_url =
- base::StringPrintf(kAppRemotingTestEndpointBase, environment_qualifier);
+ if (service_environment == kDeveloperEnvironment) {
+ base_service_url = base::StringPrintf(kAppRemotingTestEndpointBase,
+ kAppRemotingDevEndpointQualifier);
}
return base_service_url;
« no previous file with comments | « remoting/test/app_remoting_service_urls.h ('k') | remoting/test/app_remoting_test_driver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698