Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1357973002: Removing Test and Staging environments from App Remoting Test Driver tool. (Closed)

Created:
5 years, 3 months ago by joedow
Modified:
5 years, 3 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing Test and Staging environments from App Remoting Test Driver tool. Since these environments are no longer present, I am removing them from the test tool to prevent anyone from attempting to target them. BUG= Committed: https://crrev.com/f8b92398a67600e4facd96ce2f20421374debba6 Cr-Commit-Position: refs/heads/master@{#350256}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixing unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -171 lines) Patch
M remoting/test/app_remoting_report_issue_request_unittest.cc View 1 7 chunks +5 lines, -55 lines 0 comments Download
M remoting/test/app_remoting_service_urls.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/test/app_remoting_service_urls.cc View 2 chunks +3 lines, -23 lines 0 comments Download
M remoting/test/app_remoting_test_driver.cc View 3 chunks +1 line, -22 lines 0 comments Download
M remoting/test/remote_host_info_fetcher_unittest.cc View 7 chunks +23 lines, -68 lines 0 comments Download
M testing/chromoting/app_remoting_integration_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
joedow
Removing deprecated environments from the App Remoting Test Driver tool. PTAL!
5 years, 3 months ago (2015-09-21 19:28:30 UTC) #2
garykac
https://codereview.chromium.org/1357973002/diff/1/remoting/test/app_remoting_report_issue_request_unittest.cc File remoting/test/app_remoting_report_issue_request_unittest.cc (left): https://codereview.chromium.org/1357973002/diff/1/remoting/test/app_remoting_report_issue_request_unittest.cc#oldcode178 remoting/test/app_remoting_report_issue_request_unittest.cc:178: SetFakeResponse(GURL(staging_service_environment_url_), kReportIssueResponse, Not dev_service_environment_url_?
5 years, 3 months ago (2015-09-21 23:11:04 UTC) #3
joedow
https://codereview.chromium.org/1357973002/diff/1/remoting/test/app_remoting_report_issue_request_unittest.cc File remoting/test/app_remoting_report_issue_request_unittest.cc (left): https://codereview.chromium.org/1357973002/diff/1/remoting/test/app_remoting_report_issue_request_unittest.cc#oldcode178 remoting/test/app_remoting_report_issue_request_unittest.cc:178: SetFakeResponse(GURL(staging_service_environment_url_), kReportIssueResponse, On 2015/09/21 23:11:04, garykac wrote: > Not ...
5 years, 3 months ago (2015-09-21 23:41:34 UTC) #4
joedow
Ping!
5 years, 3 months ago (2015-09-22 18:06:53 UTC) #5
garykac
lgtm
5 years, 3 months ago (2015-09-22 20:41:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357973002/20001
5 years, 3 months ago (2015-09-22 20:50:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-22 22:21:08 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 22:21:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f8b92398a67600e4facd96ce2f20421374debba6
Cr-Commit-Position: refs/heads/master@{#350256}

Powered by Google App Engine
This is Rietveld 408576698