Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 1357953002: Replace the existing SpdyHeaderBlock typedef with a class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add NET_EXPORT to fix compile error on win_chromium_compile_dbg_ng. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/devtools_netlog_observer.cc ('k') | net/net.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index c9e96de2996da7f582f4f19fa3558ef4e3f1aeaf..3b9bf30a9811cbd20bbbb3c6d3f535846c954e61 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -3957,14 +3957,14 @@ TEST_P(HttpNetworkTransactionTest,
// CONNECT to mail.example.org:443 via SPDY.
SpdyHeaderBlock connect2_block;
+ spdy_util_.MaybeAddVersionHeader(&connect2_block);
connect2_block[spdy_util_.GetMethodKey()] = "CONNECT";
if (GetParam() == kProtoHTTP2) {
connect2_block[spdy_util_.GetHostKey()] = "mail.example.org:443";
} else {
- connect2_block[spdy_util_.GetPathKey()] = "mail.example.org:443";
connect2_block[spdy_util_.GetHostKey()] = "mail.example.org";
+ connect2_block[spdy_util_.GetPathKey()] = "mail.example.org:443";
}
- spdy_util_.MaybeAddVersionHeader(&connect2_block);
scoped_ptr<SpdyFrame> connect2(
spdy_util_.ConstructSpdySyn(3, connect2_block, LOWEST, false, false));
@@ -12604,11 +12604,11 @@ TEST_P(HttpNetworkTransactionTest, DoNotUseSpdySessionForHttpOverTunnel) {
// SPDY GET for HTTP URL (through the proxy, but not the tunnel).
SpdyHeaderBlock req2_block;
+ spdy_util_.MaybeAddVersionHeader(&req2_block);
req2_block[spdy_util_.GetMethodKey()] = "GET";
- req2_block[spdy_util_.GetPathKey()] = "/";
req2_block[spdy_util_.GetHostKey()] = "www.example.org:8080";
req2_block[spdy_util_.GetSchemeKey()] = "http";
- spdy_util_.MaybeAddVersionHeader(&req2_block);
+ req2_block[spdy_util_.GetPathKey()] = "/";
scoped_ptr<SpdyFrame> req2(
spdy_util_.ConstructSpdySyn(3, req2_block, MEDIUM, false, true));
« no previous file with comments | « content/browser/devtools/devtools_netlog_observer.cc ('k') | net/net.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698