Replace the existing SpdyHeaderBlock typedef with a class.

net/tools/quic/quic_client_bin.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A binary wrapper for QuicClient.
 // Connects to a host using QUIC, sends a request to the provided URL, and
 // displays the response.
 //
 // Some usage examples:
 //
@@ skipping 38 matching lines @@
 #include "net/base/ip_endpoint.h"
 #include "net/base/net_errors.h"
 #include "net/base/privacy_mode.h"
 #include "net/cert/cert_verifier.h"
 #include "net/http/transport_security_state.h"
 #include "net/log/net_log.h"
 #include "net/quic/crypto/proof_verifier_chromium.h"
 #include "net/quic/quic_protocol.h"
 #include "net/quic/quic_server_id.h"
 #include "net/quic/quic_utils.h"
+#include "net/spdy/spdy_header_block.h"
 #include "net/tools/epoll_server/epoll_server.h"
 #include "net/tools/quic/quic_client.h"
 #include "net/tools/quic/spdy_balsa_utils.h"
 #include "net/tools/quic/synchronous_host_resolver.h"
 #include "url/gurl.h"
 
 using base::StringPiece;
 using net::CertVerifier;
 using net::ProofVerifierChromium;
 using net::TransportSecurityState;
@@ skipping 199 matching lines @@
   // Send the request.
   net::SpdyHeaderBlock header_block =
       net::tools::SpdyBalsaUtils::RequestHeadersToSpdyHeaders(
           headers, client.session()->connection()->version());
   client.SendRequestAndWaitForResponse(headers, FLAGS_body, /*fin=*/true);
 
   // Print request and response details.
   if (!FLAGS_quiet) {
     cout << "Request:" << endl;
     cout << "headers:" << endl;
-    for (const std::pair<string, string>& kv : header_block) {
+    for (const auto& kv : header_block) {

[Ryan Hamilton, 2015/09/24 17:54:06]

Out of curiosity, what would the explicit type be here?

[Bence, 2015/09/24 21:14:51]

pair<StringPiece, StringPiece>.  Same in quic_simple_client_bin.cc.  If you need
to ask, maybe it would be better do spell it out explicitly.  I'm not a big fan
of auto anyway, but this is how it got landed internally.

[Ryan Hamilton, 2015/09/24 22:25:55]

meh. If it were me, I would spell it out, but it's not the end of the world in
this case.

       cout << " " << kv.first << ": " << kv.second << endl;
     }
     cout << "body: " << FLAGS_body << endl;
     cout << endl;
     cout << "Response:" << endl;
     cout << "headers: " << client.latest_response_headers() << endl;
     cout << "body: " << client.latest_response_body() << endl;
   }
 
   size_t response_code = client.latest_response_code();
   if (response_code >= 200 && response_code < 300) {
     cout << "Request succeeded (" << response_code << ")." << endl;
     return 0;
   } else if (response_code >= 300 && response_code < 400) {
     if (FLAGS_redirect_is_success) {
       cout << "Request succeeded (redirect " << response_code << ")." << endl;
       return 0;
     } else {
       cout << "Request failed (redirect " << response_code << ")." << endl;
       return 1;
     }
   } else {
     cerr << "Request failed (" << response_code << ")." << endl;
     return 1;
   }
 }