Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 1357943003: I444ToABGR for skcanvas in one step. (Closed)

Created:
5 years, 3 months ago by fbarchard1
Modified:
5 years, 3 months ago
Reviewers:
fbarchard, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

I444ToABGR for skcanvas in one step. libyuv supported I444ToARGB in the past, but not ABGR, so it was a 2 step process. libyuv r1487 supports I444ToABGR in one step. BUG=libyuv:490 Committed: https://crrev.com/5f9bbcb93f2723fde10c8a26240fb5a9f6f12909 Cr-Commit-Position: refs/heads/master@{#350282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M media/blink/skcanvas_video_renderer.cc View 4 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fbarchard
Added libyuv:I444ToABGR in r1487 to allow skvideocanvas to convert bt.601 YUV 444 to ABGR for ...
5 years, 3 months ago (2015-09-22 21:03:04 UTC) #2
DaleCurtis
lgtm
5 years, 3 months ago (2015-09-22 23:10:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357943003/1
5 years, 3 months ago (2015-09-23 00:51:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 00:59:32 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 01:03:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f9bbcb93f2723fde10c8a26240fb5a9f6f12909
Cr-Commit-Position: refs/heads/master@{#350282}

Powered by Google App Engine
This is Rietveld 408576698