Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 135783003: deprecate tools/test_rendering.py and tools/test_pictures.py (Closed)

Created:
6 years, 11 months ago by epoger
Modified:
6 years, 11 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

deprecate tools/test_rendering.py and tools/test_pictures.py they will be removed entirely on/after Feb 1 unless there is objection BUG=skia:1943 Committed: http://code.google.com/p/skia/source/detail?r=13065

Patch Set 1 #

Patch Set 2 : March -> Feb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M tools/test_pictures.py View 1 2 chunks +7 lines, -1 line 0 comments Download
M tools/test_rendering.py View 1 7 chunks +14 lines, -1 line 0 comments Download
M tools/tests/render_pictures_test.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Ready for review at patchset 1. Eric, putting you as reviewer because you and I ...
6 years, 11 months ago (2014-01-14 16:23:14 UTC) #1
borenet
LGTM, but I think the approach I'd take would be: - Send an email to ...
6 years, 11 months ago (2014-01-14 16:31:12 UTC) #2
epoger
On 2014/01/14 16:31:12, borenet wrote: > LGTM, but I think the approach I'd take would ...
6 years, 11 months ago (2014-01-14 16:49:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/135783003/50001
6 years, 11 months ago (2014-01-14 16:50:04 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 17:01:31 UTC) #5
Message was sent while issue was closed.
Change committed as 13065

Powered by Google App Engine
This is Rietveld 408576698