Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1357823003: SK_API for include/gpu/gl/GrGLInterface.h (Closed)

Created:
5 years, 3 months ago by hal.canary
Modified:
5 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SK_API for include/gpu/gl/GrGLInterface.h Committed: https://skia.googlesource.com/skia/+/0fc1dbe59271d507e1435a5d06bbfc2ec5bb4816

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M include/gpu/gl/GrGLInterface.h View 1 chunk +4 lines, -4 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
hal.canary
PTAL
5 years, 3 months ago (2015-09-21 15:10:17 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1357823003/diff/1/include/gpu/gl/GrGLInterface.h File include/gpu/gl/GrGLInterface.h (right): https://codereview.chromium.org/1357823003/diff/1/include/gpu/gl/GrGLInterface.h#newcode71 include/gpu/gl/GrGLInterface.h:71: const SK_API GrGLInterface* GrGLCreateNullInterface(); should we make this ...
5 years, 3 months ago (2015-09-21 15:17:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357823003/1
5 years, 3 months ago (2015-09-21 15:17:54 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 15:22:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0fc1dbe59271d507e1435a5d06bbfc2ec5bb4816

Powered by Google App Engine
This is Rietveld 408576698