Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Issue 1357813002: bluetooth: android: Rename FakeBluetoothLeScanner.mCallback to mScanCallback. (Closed)

Created:
5 years, 3 months ago by scheib
Modified:
5 years, 3 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bta-create-gatt-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: android: Rename FakeBluetoothLeScanner.mCallback to mScanCallback. This file now contains multiple callback members due to addition of mGattCallback. Instead of having them all 'mCallback' more unique names are used, and this patch updates the initial 'mCallback' to use the same style. BUG=490430 Committed: https://crrev.com/4fa991d046bb40294bb3517dc7ad0f05d19b8b49 Cr-Commit-Position: refs/heads/master@{#350372}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java View 5 chunks +11 lines, -11 lines 4 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
scheib
5 years, 3 months ago (2015-09-20 04:17:54 UTC) #2
Jeffrey Yasskin
lgtm https://codereview.chromium.org/1357813002/diff/1/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java File device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java (right): https://codereview.chromium.org/1357813002/diff/1/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java#newcode66 device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java:66: uuids)); This indentation is weird. https://codereview.chromium.org/1357813002/diff/1/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java#newcode77 device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java:77: uuids)); ...
5 years, 3 months ago (2015-09-21 18:30:53 UTC) #3
scheib
https://codereview.chromium.org/1357813002/diff/1/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java File device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java (right): https://codereview.chromium.org/1357813002/diff/1/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java#newcode66 device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java:66: uuids)); On 2015/09/21 18:30:52, Jeffrey Yasskin wrote: > This ...
5 years, 3 months ago (2015-09-21 19:53:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357813002/1
5 years, 3 months ago (2015-09-23 21:17:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 21:49:01 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 21:50:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fa991d046bb40294bb3517dc7ad0f05d19b8b49
Cr-Commit-Position: refs/heads/master@{#350372}

Powered by Google App Engine
This is Rietveld 408576698