Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1357803004: Reland of Add a NavigationThrottle to the public content/ interface (Closed)

Created:
5 years, 3 months ago by huangs
Modified:
5 years, 3 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@navigation-api
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add a NavigationThrottle to the public content/ interface (patchset #1 id:1 of https://codereview.chromium.org/1350913008/ ) Reason for revert: Test failure on linux_chromium_chromeos_rel_ng is fixed, but to be sure (e.g., it's not a problem with test bot?) let's see if bug reappears when we undo the revert. Original issue's description: > Revert of Add a NavigationThrottle to the public content/ interface (patchset #18 id:350001 of https://codereview.chromium.org/1269813002/ ) > > Reason for revert: > linux_chromiium_chromeos_rel_ng => browser_test => SelectFileDialogExtensionBrowserTest seems to faile a lot, testing. > > Original issue's description: > > Add a NavigationThrottle to the public content/ interface > > > > This CL adds a NavigationThrottle class to the public content/ interface. A NavigationThrottle is used to control the flow of navigations. It lives entirely on the UI thread. Eventually, all components that want the functionality of a ResourceThrottle for navigations should transition to a NavigationThrottle: the new architecture for navigations (browser-side navigation) will not support ResourceThrottles for main resources load. See https://docs.google.com/document/d/1ICLLQoC9EsZ-bWH4ZKRhPCIoZKn6pOj02SlGl6SKH6Y/edit?pli=1#heading=h.fmxjmgvbgg7x for the design doc. > > > > This Cl also transition the InterceptNavigationresourceThrottle to the Navigationthrottle model. > > BUG=504347 > > > > Committed: https://crrev.com/394057986ff5d00a841a976f3bd8d599603acaa1 > > Cr-Commit-Position: refs/heads/master@{#350092} > > TBR=nasko@chromium.org,davidben@chromium.org,carlosk@chromium.org,fdegans@chromium.org,avi@chromium.org,creis@chromium.org,nick@chromium.org,asargent@chromium.org,sky@chromium.org,mnaganov@chromium.org,clamy@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=504347 > > Committed: https://crrev.com/2ad8595f7a925851acd3ae733f359fafe6223ff5 > Cr-Commit-Position: refs/heads/master@{#350157} TBR=nasko@chromium.org,davidben@chromium.org,carlosk@chromium.org,fdegans@chromium.org,avi@chromium.org,creis@chromium.org,nick@chromium.org,asargent@chromium.org,sky@chromium.org,mnaganov@chromium.org,clamy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1026 lines, -821 lines) Patch
M android_webview/browser/aw_content_browser_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/apps/app_url_redirector.h View 1 chunk +10 lines, -12 lines 0 comments Download
M chrome/browser/apps/app_url_redirector.cc View 3 chunks +31 lines, -38 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 4 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +2 lines, -19 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/navigation_interception.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M components/navigation_interception/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M components/navigation_interception/intercept_navigation_delegate.h View 3 chunks +8 lines, -8 lines 0 comments Download
M components/navigation_interception/intercept_navigation_delegate.cc View 2 chunks +8 lines, -5 lines 0 comments Download
D components/navigation_interception/intercept_navigation_resource_throttle.h View 1 chunk +0 lines, -63 lines 0 comments Download
D components/navigation_interception/intercept_navigation_resource_throttle.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc View 1 chunk +0 lines, -481 lines 0 comments Download
A components/navigation_interception/intercept_navigation_throttle.h View 1 chunk +51 lines, -0 lines 0 comments Download
A components/navigation_interception/intercept_navigation_throttle.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A components/navigation_interception/intercept_navigation_throttle_unittest.cc View 1 chunk +165 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.h View 6 chunks +57 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 5 chunks +131 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigation_request.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_request.cc View 3 chunks +32 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
A content/browser/loader/navigation_resource_throttle.h View 1 chunk +44 lines, -0 lines 0 comments Download
A content/browser/loader/navigation_resource_throttle.cc View 1 chunk +154 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +5 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 3 chunks +10 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/browser/navigation_handle.h View 2 chunks +84 lines, -7 lines 0 comments Download
A content/public/browser/navigation_handle.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A content/public/browser/navigation_throttle.h View 1 chunk +43 lines, -0 lines 0 comments Download
A content/public/browser/navigation_throttle.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M content/test/web_contents_observer_sanity_checker.cc View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
huangs
Created Reland of Add a NavigationThrottle to the public content/ interface
5 years, 3 months ago (2015-09-22 16:37:06 UTC) #1
huangs
5 years, 3 months ago (2015-09-22 17:19:05 UTC) #2
Confirmed that the same error would return if we reland the CL.  Closing this
CL.

Powered by Google App Engine
This is Rietveld 408576698