Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 1357783002: assert_with_message_test incorrectly suppressed for dart2js (Closed)

Created:
5 years, 3 months ago by sra1
Modified:
5 years, 3 months ago
Reviewers:
terry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

assert_with_message_test incorrectly suppressed for dart2js Some of the dart2js bots are red due to this. I'm not sure what the Dartium problem is, considering this is a dart2js-only test. TBR=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/fb740933eed6b2abe33cce60dd287270648dd0dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
sra1
5 years, 3 months ago (2015-09-19 01:42:08 UTC) #2
sra1
5 years, 3 months ago (2015-09-19 01:42:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fb740933eed6b2abe33cce60dd287270648dd0dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698