ios/web/web_state/ui/crw_web_controller_unittest.mm - Issue 1357773002: WKWebView: Implemented recoverable SSL interstitials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller_unittest.mm

Issue 1357773002: WKWebView: Implemented recoverable SSL interstitials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lock_coloring

Patch Set: Addressed unit tests review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/web/net/crw_cert_verification_controller_unittest.mm ('k') | ios/web/web_state/ui/crw_wk_web_view_web_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/web/web_state/ui/crw_web_controller_unittest.mm

diff --git a/ios/web/web_state/ui/crw_web_controller_unittest.mm b/ios/web/web_state/ui/crw_web_controller_unittest.mm

index 980b135da468da2cb0aa7e11c680efb184757c76..bb06926d9f09afef34097ae26d66055b177357cb 100644

--- a/ios/web/web_state/ui/crw_web_controller_unittest.mm

+++ b/ios/web/web_state/ui/crw_web_controller_unittest.mm

@@ -908,7 +908,7 @@ TEST_F(CRWWKWebViewWebControllerTest, SSLCertError) {

EXPECT_EQ(web::SECURITY_STYLE_AUTHENTICATION_BROKEN,

[mockDelegate_ SSLStatus].security_style);

EXPECT_FALSE([mockDelegate_ recoverable]);

- EXPECT_FALSE([mockDelegate_ shouldContinueCallback]);

+ EXPECT_TRUE([mockDelegate_ shouldContinueCallback]);

}

#endif // !defined(ENABLE_CHROME_NET_STACK_FOR_WKWEBVIEW)

« no previous file with comments | « ios/web/net/crw_cert_verification_controller_unittest.mm ('k') | ios/web/web_state/ui/crw_wk_web_view_web_controller.mm » ('j') | no next file with comments »