Source/core/loader/DocumentLoader.cpp - Issue 1357763002: DocumentLoader::isCommittedButEmpty is timing-dependent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/DocumentLoader.cpp

Issue 1357763002: DocumentLoader::isCommittedButEmpty is timing-dependent. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/DocumentLoader.cpp

diff --git a/Source/core/loader/DocumentLoader.cpp b/Source/core/loader/DocumentLoader.cpp

index 3e985b4db5641f6800d4e2b23dea2673abf356dd..e9d4e700405bc983e3156bd60803f38747c11552 100644

--- a/Source/core/loader/DocumentLoader.cpp

+++ b/Source/core/loader/DocumentLoader.cpp

@@ -294,7 +294,7 @@ void DocumentLoader::finishedLoading(double finishTime)

if (!m_mainDocumentError.isNull())

return;

- m_state = MainResourceDone;

+ m_state = m_mainResource && m_mainResource->encodedSize() ? MainResourceDone : MainResourceDoneEmpty;

// If the document specified an application cache manifest, it violates the author's intent if we store it in the memory cache

// and deny the appcache the chance to intercept it in the future, so remove from the memory cache.