DocumentLoader::isCommittedButEmpty is timing-dependent.

DocumentLoader::isCommittedButEmpty is timing-dependent.

It's possible for it to be checked after the DocumentLoader has finished, at
which point it will incorrectly return false.

BUG=520389

[Nate Chapin, 2015-09-18 23:57:30]

japhet@chromium.org changed reviewers:
+ dcheng@chromium.org

[Nate Chapin, 2015-09-18 23:57:31]

PTAL

[dcheng, 2015-09-21 16:43:52]

lgtm

https://codereview.chromium.org/1357763002/diff/20001/Source/core/loader/Docu...
File Source/core/loader/DocumentLoader.h (right):

https://codereview.chromium.org/1357763002/diff/20001/Source/core/loader/Docu...
Source/core/loader/DocumentLoader.h:238: MainResourceDoneEmpty
Would it make sense to call this "DoneButEmpty" to match the "CommittedButEmpty"
name earlier?

[Nate Chapin, 2015-09-21 16:45:30]

https://codereview.chromium.org/1357763002/diff/20001/Source/core/loader/Docu...
File Source/core/loader/DocumentLoader.h (right):

https://codereview.chromium.org/1357763002/diff/20001/Source/core/loader/Docu...
Source/core/loader/DocumentLoader.h:238: MainResourceDoneEmpty
On 2015/09/21 16:43:52, dcheng wrote:
> Would it make sense to call this "DoneButEmpty" to match the
"CommittedButEmpty"
> name earlier?

Yeah, probably. Will update before landing.

[Nate Chapin, 2015-09-21 18:13:19]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2015-09-21 18:13:19]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1357763002/#ps40001
(title: "Empty->ButEmpty")

[commit-bot: I haz the power, 2015-09-21 18:13:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1357763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1357763002/40001

[commit-bot: I haz the power, 2015-09-21 18:59:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-21 18:59:00]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Nate Chapin, 2015-09-22 00:01:01]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2015-09-22 00:01:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1357763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1357763002/40001

[commit-bot: I haz the power, 2015-09-22 01:24:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 01:24:42]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nate Chapin, 2015-09-22 17:06:00]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2015-09-22 17:06:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1357763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1357763002/40001

[commit-bot: I haz the power, 2015-09-22 18:32:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 18:32:40]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nate Chapin, 2015-09-22 20:21:14]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2015-09-22 20:21:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1357763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1357763002/40001

[commit-bot: I haz the power, 2015-09-22 21:43:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 21:43:45]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nate Chapin, 2015-09-22 22:26:37]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2015-09-22 22:26:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1357763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1357763002/40001

[Nate Chapin, 2015-10-22 22:47:15]

Description was changed from

==========
DocumentLoader::isCommittedButEmpty is timing-dependent.

It's possible for it to be checked after the DocumentLoader has finished, at
which point it will incorrectly return false.

BUG=520389
==========

to

==========
DocumentLoader::isCommittedButEmpty is timing-dependent.

It's possible for it to be checked after the DocumentLoader has finished, at
which point it will incorrectly return false.

BUG=520389
==========