Issue 1357753002: win: remove unused fields from CrashpadInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1357753002: win: remove unused fields from CrashpadInfo (Closed)

Created:
5 years, 3 months ago by scottmg

Modified:
5 years, 3 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@wow64-exception-and-restructure

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

win: remove unused fields from CrashpadInfo These were made unnecessary after changing how registration works, but I forgot to actually delete them from CrashpadInfo. R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/96f687b5675100dc249c009b4e276510f704598d

Patch Set 2 : . #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -24 lines)			Patch
	M	client/crashpad_info.h	View		2 chunks	+0 lines, -17 lines	0 comments	Download
	M	client/crashpad_info.cc	View	1	1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM https://codereview.chromium.org/1357753002/diff/1/client/crashpad_info.cc File client/crashpad_info.cc (right): https://codereview.chromium.org/1357753002/diff/1/client/crashpad_info.cc#newcode103 client/crashpad_info.cc:103: { Move on up!

5 years, 3 months ago (2015-09-18 21:59:13 UTC) #2

scottmg

https://codereview.chromium.org/1357753002/diff/1/client/crashpad_info.cc File client/crashpad_info.cc (right): https://codereview.chromium.org/1357753002/diff/1/client/crashpad_info.cc#newcode103 client/crashpad_info.cc:103: { On 2015/09/18 21:59:12, Mark Mentovai - August is ...

5 years, 3 months ago (2015-09-18 22:19:40 UTC) #3

scottmg

5 years, 3 months ago (2015-09-18 22:20:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
96f687b5675100dc249c009b4e276510f704598d (presubmit successful).

Expand Messages | Collapse Messages

Issue 1357753002: win: remove unused fields from CrashpadInfo (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages