Issue 1357733007: Disable EtwTraceControllerTest.EnableDisable again

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1357733007: Disable EtwTraceControllerTest.EnableDisable again (Closed)

Created:
5 years, 3 months ago by brucedawson

Modified:
5 years, 3 months ago

Reviewers:
danakj

CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable EtwTraceControllerTest.EnableDisable again Spelling counts. DISABLE_ doesn't work as well as DISABLED_. Tested correctly this time to make sure it is actually disabled. R=danakj@chromium.org BUG=525297, 534184 Committed: https://crrev.com/1a829413d5e40d132a83c31ba4a2b89a095216d2 Cr-Commit-Position: refs/heads/master@{#349958}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/win/event_trace_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

brucedawson

Oops. This time I tested with --gtest_filter=EtwTraceControllerTest.* so that I know I got it right.

5 years, 3 months ago (2015-09-21 17:25:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357733007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357733007/1

5 years, 3 months ago (2015-09-21 17:34:03 UTC) #4

commit-bot: I haz the power

5 years, 3 months ago (2015-09-21 17:51:36 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1a829413d5e40d132a83c31ba4a2b89a095216d2
Cr-Commit-Position: refs/heads/master@{#349958}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages