Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1357713008: Fix race and error case in GN auto-roller script. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix race and error case in GN auto-roller script. There were two issues in the GN auto roller script; in the first case, if we hit a race in Rietveld and did not find any try jobs posted, we would return an error code rather than an empty dict of job results. Once that was fixed, we might still not have results from all the bots we were waiting on, so we might exit earlier. This patch fixes things so we wait for results for all of the try jobs we posted. TBR=brettw@chromium.org BUG= Committed: https://crrev.com/a6108a3461418a0b9928a40e712181876e2ca3f4 Cr-Commit-Position: refs/heads/master@{#349831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/gn/bin/roll_gn.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
5 years, 3 months ago (2015-09-19 01:00:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357713008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357713008/1
5 years, 3 months ago (2015-09-19 01:00:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-19 01:12:21 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a6108a3461418a0b9928a40e712181876e2ca3f4 Cr-Commit-Position: refs/heads/master@{#349831}
5 years, 3 months ago (2015-09-19 01:13:06 UTC) #5
brettw
5 years, 3 months ago (2015-09-19 03:54:15 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698