Issue 1357713006: Remove redundant call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1357713006: Remove redundant call (Closed)

Created:
5 years, 3 months ago by vsm

Modified:
5 years, 3 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove redundant call R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/8b8d2e2f0580260c687ca30b7614ea9608ba807d

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	lib/src/compiler.dart	View		1 chunk	+1 line, -3 lines	1 comment	Download
	M	test/codegen_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

https://codereview.chromium.org/1357713006/diff/1/lib/src/compiler.dart File lib/src/compiler.dart (left): https://codereview.chromium.org/1357713006/diff/1/lib/src/compiler.dart#oldcode292 lib/src/compiler.dart:292: enableDevCompilerInference(context, options.strongOptions); I think this call is redundant with ...

5 years, 3 months ago (2015-09-18 22:29:39 UTC) #2

vsm

5 years, 3 months ago (2015-09-18 22:40:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8b8d2e2f0580260c687ca30b7614ea9608ba807d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages