Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 13577003: [Android] Specify dependency files for instrumentation tests. (Closed)

Created:
7 years, 8 months ago by frankf
Modified:
7 years, 8 months ago
Reviewers:
craigdh, nilesh
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

[Android] Specify dependency files for instrumentation tests. Add a virtual PushDependencies() method to base test runner which will push all files to devices during setup. BUG=226058 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192167

Patch Set 1 #

Patch Set 2 : Fix host-driven tests #

Patch Set 3 : Minor change: Also add ssl/certs dep to contentshell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -12 lines) Patch
M build/android/pylib/base/base_test_runner.py View 1 chunk +5 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 2 chunks +2 lines, -4 lines 0 comments Download
M build/android/pylib/host_driven/run_python_tests.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/instrumentation/test_package.py View 1 chunk +6 lines, -0 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 2 4 chunks +32 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
frankf
7 years, 8 months ago (2013-04-03 19:27:52 UTC) #1
nilesh
On 2013/04/03 19:27:52, frankf wrote: lGTM
7 years, 8 months ago (2013-04-03 19:37:52 UTC) #2
craigdh
lgtm.
7 years, 8 months ago (2013-04-03 20:29:14 UTC) #3
frankf
7 years, 8 months ago (2013-04-03 21:51:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r192167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698